fix(tests): update proxy env var test assertions for httpx 0.28#42
Open
mattcarrollcode wants to merge 1 commit intometa-llama:mainfrom
Open
fix(tests): update proxy env var test assertions for httpx 0.28#42mattcarrollcode wants to merge 1 commit intometa-llama:mainfrom
mattcarrollcode wants to merge 1 commit intometa-llama:mainfrom
Conversation
httpx 0.28 includes default fallback mounts (None transports) in _mounts, so filtering for non-None transports and checking the proxy pattern exists is more robust than asserting exact mount count.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_proxy_environment_variablesin both sync and async client test classes_mounts, so the old assertionlen(mounts) == 1failshttps://proxy pattern exists instead of checking exact countTest plan
pytest tests/test_client.py -k test_proxy_environment_variables— both tests pass