Sync develop into main (iOS inset fix + screenshot refresh)#47
Merged
Conversation
A page sheet already sits below the status bar, but CMP 1.11 sources safeDrawing from the UIWindow, so the sheet paid the status-bar inset twice — a ~62pt dead band above the header (iPhone 16 Pro). presentSharingan() now presents an internal sheet variant that provides LocalStripTopInset, and the Scaffold drops the top side of safeDrawing when it is set. The public SharinganViewController() factory is unchanged, so full-screen/embedded hosts keep their top inset. No public API changes (apiCheck + checkApiParity green). Fixes #42 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Kotlin/Native forbids ',' in identifiers; commonTest also compiles for the iOS targets, so the #42 inset test broke compileTestKotlinIosArm64. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review polish for #42: the raw-VC KDoc now warns that a self-presented page sheet shows the phantom top gap and points at presentSharingan(); the inset test also pins the right side surviving the strip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fix(ios): strip phantom top inset when presented as a page sheet (#42)
All six README iOS shots retaken on an iPhone 16 Pro simulator (1206x2622, simctl io screenshot) with the same seeded IoT scenario. Only intended visual change: the Sharingan header now sits flush at the sheet top — the phantom gray band above it is gone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
docs: recapture iOS screenshots after sheet inset fix (#42)
Same six PNGs as docs/screenshots/ios/ — the landing gallery and docs pages now show the flush sheet header too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
site: sync iOS screenshot copies with the #42 recapture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings main up to date with develop:
Merging triggers the Pages deploy automatically (
site/**reaches main). Supersedes #46.🤖 Generated with Claude Code