Human-readable deployment duration output; release v1.3.2

[Joel Platek (VAsHachiRoku)]

Summary

Renders deployment duration in human-readable form instead of raw milliseconds (issue #34). Adds a Format-TierModelDuration public cmdlet and routes the nine Deploy-TierModel.ps1 console Duration: sites through it.

Output tiers (floor-based, never zero):

Input	Output
0 / < 1ms	<1ms
1–999 ms	Xms
1–59 s	Xs
>= 60 s	Xm Ys

Log lines (Write-TierModelLog) keep raw milliseconds for machine parsing.

Design notes

• Uses [double] (not [long]) — real DurationMs values are doubles (e.g. 2254.1343); a [long] cast truncates 0.4ms -> 0ms.
• A < 1ms gate guarantees a non-zero display for any input (an idempotent single-object create is sub-second) — never 0m 0s.
• The minute tier uses explicit floor arithmetic, not [int][TimeSpan]::TotalMinutes, which banker's-rounds (90000ms would wrongly show 2m 30s) and is non-monotonic.

Release

• Module version 1.3.1 -> 1.3.2; the version-pinned manifest and module tests were updated in lockstep.
• The [1.3.2] CHANGELOG section also captures the two changes already on main since the 1.3.1 re-release: the Best Practices / AD Hardening documentation page (Add Manager attribute on privileged accounts for delegated group population #33) and the green canonical-overlap remediation message.

Testing

• New tests/Unit.FormatDuration.Tests.ps1 — 23 cases across all four tiers, including 90000 / 119999 / 120000 banker's-rounding regression guards.
• Wiring-proof integration assertions: mock DurationMs 2254 -> "Duration: 2s", all-converged no-op -> "Duration: <1ms", aggregate 140000 -> "Duration: 2m 20s".
• Full suite: 1,652 passing / 0 failures, 88.93% coverage (Pester 5.9.0).
• Lab-validated on a live DC: -OuOnly -ConfirmApply -> Duration: 2s; delete 1 OU + re-run -> Duration: 74ms; -FullDeployment -ConfirmApply -> Duration: 1m 47s.

Closes #34

[Copilot]

Pull request overview

This PR introduces a reusable duration-formatting primitive to make Deploy-TierModel.ps1 console Duration: output human-readable (ms / s / m+s) while keeping machine-parsable logs in raw milliseconds, and bumps the module release to v1.3.2.

Changes:

• Added a new public cmdlet Format-TierModelDuration and exported it from the module manifest.
• Updated all console Duration: outputs in Deploy-TierModel.ps1 to use the new formatter (leaving Write-TierModelLog duration strings unchanged).
• Updated module versioning + added/updated unit and integration tests, plus release documentation (README/CHANGELOG).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Unit.ModuleManifest.Tests.ps1	Updates version assertion, allows Format-* verb, and asserts Format-TierModelDuration is exported.
tests/Unit.FormatDuration.Tests.ps1	Adds dedicated unit coverage for the 4-tier duration formatting contract.
tests/Integration.Module.Tests.ps1	Updates version assertion for the v1.3.2 release.
tests/Integration.Deploy.Tests.ps1	Updates deploy output assertions and adds wiring-proof coverage for the minute-tier display.
README.md	Refreshes reported test counts and coverage metrics to reflect the new test run.
modules/TierModel/TierModel.psd1	Bumps module version to 1.3.2 and exports Format-TierModelDuration.
modules/TierModel/public/Format-TierModelDuration.ps1	Adds the new duration formatting cmdlet implementation.
Deploy-TierModel.ps1	Routes console Duration: output through Format-TierModelDuration at all call sites.
CHANGELOG.md	Adds the v1.3.2 release notes section describing the duration formatting change and related items.
.squad/agents/wolverine/history.md	Updates agent history with the completed test deliverables and measured metrics.
.squad/agents/beast/history.md	Updates agent history with the design/implementation notes for the duration formatting work.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

.squad/agents/beast/history.md:61

• This session note says the module version stayed at 1.3.1, but this PR bumps the manifest/module tests to 1.3.2. Since this is meant to be a historical record, it should reflect the actual version change in the same PR.

### IMPLEMENTATION COMPLETE (2026-08-24) — production code only, no tests
- `modules/TierModel/public/Format-TierModelDuration.ps1` — CREATED (4 tiers, all floor-based, parse clean)
- `modules/TierModel/TierModel.psd1` — `'Format-TierModelDuration'` added to FunctionsToExport after `'Copy-TierModelAdmx'`
- `Deploy-TierModel.ps1` — 9 Write-Host sites updated; L559/L701 log lines left raw
- `CHANGELOG.md` — Unreleased entry added (issue #34)
- 12/12 smoke-test cases passed including the two banker's-rounding regression cases (90000ms→1m 30s, 119999ms→1m 59s)
- ModuleVersion stays 1.3.1 (not bumped per Joel instruction)
- Tests: NOT written — Wolverine phase after lab validation

modules/TierModel/public/Format-TierModelDuration.ps1:26

• Comment-based help says the expected input domain is "finite, non-negative" milliseconds, but the implementation explicitly treats negative values as a valid case (returns '<1ms'). This is a documentation inconsistency that can confuse callers about whether negative durations are supported or rejected.

.PARAMETER Milliseconds
    Duration in milliseconds as a [double]. Accepts both [int] and [double]
    DurationMs values returned by module cmdlets. Expected input domain is
    finite, non-negative milliseconds.

.OUTPUTS
    [string] Human-readable duration string.

.NOTES
    Expected input domain is finite, non-negative milliseconds.