updates webgpu ep version to be decoupled from foundry local version in cpp core#758
Open
prathikr wants to merge 4 commits into
Open
updates webgpu ep version to be decoupled from foundry local version in cpp core#758prathikr wants to merge 4 commits into
prathikr wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the C++ WebGPU execution provider (EP) bootstrapper to decouple WebGPU EP package updates from Foundry Local releases by switching from a hard-coded package URL+hashes to a manifest-driven download and verification flow.
Changes:
- Fetch a platform-specific WebGPU EP package URL + expected SHA-256 hashes from a CDN-hosted JSON manifest.
- Install via a staging directory + lock file, then promote to the final install directory.
- Move binary verification to a map-driven
VerifyPackage(...)helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk_v2/cpp/src/ep_detection/webgpu_ep_bootstrapper.h | Updates class documentation and adds a VerifyPackage helper signature for manifest-driven verification. |
| sdk_v2/cpp/src/ep_detection/webgpu_ep_bootstrapper.cc | Implements manifest fetching/parsing, staging-based install, and hash verification based on manifest contents. |
baijumeswani
reviewed
Jun 8, 2026
| /// @param ep_name EP name used in warning log messages (e.g. "CUDA EP"). | ||
| /// @param logger Logger for diagnostic output. | ||
| /// @return true if every file exists and its hash matches; false otherwise. | ||
| inline bool VerifyEpPackage( |
Collaborator
There was a problem hiding this comment.
Does this need to be inlined?
| // CUDA EP — only if an NVIDIA GPU is detected | ||
| if (CudaEpBootstrapper::HasNvidiaGpu()) { | ||
| auto cuda_ep_dir = *config_.model_cache_dir + "/cuda-ep"; | ||
| auto cuda_ep_dir = cache_dir + "/cuda-ep"; |
Collaborator
There was a problem hiding this comment.
Since cache_dir is a filesystem path, can we do
const auto cache_dir = std::filesystem::path(*config_.model_cache_dir).parent_path();
const auto cuda_ep_dir = cache_dir / "cuda-ep";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.