Add OnnxDiscrepancyCheck speedup metric with default timing updates#2502
Open
xadupre wants to merge 6 commits into
Open
Add OnnxDiscrepancyCheck speedup metric with default timing updates#2502xadupre wants to merge 6 commits into
xadupre wants to merge 6 commits into
Conversation
xadupre
commented
Jun 5, 2026
Copilot
AI
changed the title
add speedup to OnnxDiscrepancyCheck
Add OnnxDiscrepancyCheck speedup metric with default timing updates
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the OnnxDiscrepancyCheck pass by adding an inference speedup measurement (ONNX vs PyTorch) and introducing configurable warmup/timing iteration settings, with updated defaults and tests to validate the new behavior.
Changes:
- Added
warmup_iterationsandtiming_iterationsconfig parameters (defaultingtiming_iterationsto5) and implemented speedup measurement with an option to skip whentiming_iterations=0. - Updated session/device setup to target the configured accelerator (with CPU fallback) and run PyTorch on the matched torch device.
- Added unit tests to validate the new default and the skip behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
olive/passes/onnx/discrepancy_check.py |
Adds speedup timing, new config params/defaults, and device-aware session/model handling. |
test/passes/onnx/test_discrepancy_check.py |
Adds tests for the new timing_iterations default and the “skip when 0” behavior. |
Comment on lines
+369
to
371
| return speedup | ||
|
|
||
| def compare_generation(self, config: type[BasePassConfig], ref_model) -> int: |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added speedup measurement for
OnnxDiscrepancyCheckand updated behavior based on review feedback:timing_iterationsdefault from10to5.timing_iterationsis set to0, speedup measurement is skipped.Checklist before requesting a review
lintrunner -a(Optional) Issue link