FileLocksmith: Fix context menu items are not localized - #49606
Open
Umoxfo wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the FileLocksmith Windows 11 context menu project’s resource-file wiring so localized strings generated from Resources.resx are actually compiled into the DLL (instead of compiling the non-localized “base” resources), addressing the issue where the context menu label remained English.
Changes:
- Switch the project to compile the generated RC (
Generated Files/FileLocksmithContextMenu.rc) rather than the base RC (FileLocksmithContextMenu.base.rc). - Treat
resource.base.handFileLocksmithContextMenu.base.rcas non-compiled inputs (None) while adding the generatedresource.has a header include for the project. - Update
.vcxproj.filtersto reflect the new generated vs. base resource file organization in Solution Explorer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules/FileLocksmith/FileLocksmithContextMenu/FileLocksmithContextMenu.vcxproj.filters | Re-categorizes base vs. generated resource/header files to match the new build inputs/outputs. |
| src/modules/FileLocksmith/FileLocksmithContextMenu/FileLocksmithContextMenu.vcxproj | Compiles the generated .rc (from resx conversion) and demotes base .rc/.h files to non-compiled inputs so localization takes effect. |
Umoxfo
marked this pull request as ready for review
August 1, 2026 19:21
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Reorganize resource items for the `FileLocksmithContextMenu` project - Mark `resource.base.h` as a non-compiled `None` - Add `Generated Files/resource.h` as a `ClInclude` - Mark `FileLocksmithContextMenu.base.rc`as a non-compiled `None` - Add `Generated Files/FileLocksmithContextMenu.rc` as a `ResourceCompile` Update the `.vcxproj.filters` accordingly to reflect the new locations and filters for header and resource files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixing the issue where Windows 11 context menu items are not localized.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Reorganize resource items for the
FileLocksmithContextMenuprojectresource.base.has a non-compiledNoneGenerated Files/resource.has aClIncludeFileLocksmithContextMenu.base.rcas a non-compiledNoneGenerated Files/FileLocksmithContextMenu.rcas aResourceCompileUpdate the
.vcxproj.filtersaccordingly to reflect the new locations and filters for header and resource files.Validation Steps Performed