Preserve empty responses in prompt normalizer batches#1506
Merged
rlundeen2 merged 1 commit intomicrosoft:mainfrom Apr 23, 2026
Merged
Preserve empty responses in prompt normalizer batches#1506rlundeen2 merged 1 commit intomicrosoft:mainfrom
rlundeen2 merged 1 commit intomicrosoft:mainfrom
Conversation
- Return explicit empty response Message (error='empty') from send_prompt_async() instead of None when a target returns no messages - Preserve write-only target (empty list) path returning request as-is - Remove None filter in send_prompt_batch_to_target_async() since send_prompt_async() now always returns a valid Message - Add regression tests for batch response alignment and [None] edge case - Fix docstring section ordering (Returns before Raises) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
force-pushed
the
preserve-batch-response-alignment
branch
from
5de8006 to
0e4b104
Compare
rlundeen2
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None/ empty target responses into explicit empty response messages inPromptNormalizer.send_prompt_async()send_prompt_batch_to_target_async()instead of filtering empty responses awayProblem
PromptNormalizer.send_prompt_async()currently returnsNonewhen a target returns no messages, and the batch helper filters thoseNoneentries out. That breaks the one-request-to-one-response contract for batch callers and can misalign downstream consumers that pair responses with their original prompt list.Validation
.venv/bin/pytest tests/unit/prompt_normalizer tests/unit/executor/promptgen/fuzzer -q.venv/bin/ruff check pyrit/prompt_normalizer/prompt_normalizer.py tests/unit/prompt_normalizer/test_prompt_normalizer.py