Skip to content

fix: Clarify emphasis test guidance to reduce false positives - #7717

Draft
v-sohmondal wants to merge 6 commits into
mainfrom
users/v-sohmondal/fixes-emphasis-test-7650
Draft

fix: Clarify emphasis test guidance to reduce false positives#7717
v-sohmondal wants to merge 6 commits into
mainfrom
users/v-sohmondal/fixes-emphasis-test-7650

Conversation

@v-sohmondal

@v-sohmondal v-sohmondal commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Summary

fixes: #7650
Updates the Semantics > Emphasis assessment to clarify that bold/italic text used purely for visual design (labels, visual separation, hierarchy) does NOT require <strong> or <em> elements—only text conveying semantic emphasis does.

Changes

src/assessments/semantics/test-steps/emphasis.tsx

  • Updated "How to Test" instructions to focus on semantic emphasis, not just visual styling

src/content/test/semantics/emphasis.tsx

  • Added guidance clarifying when semantic markup is NOT needed
  • Added new Pass/Fail examples for SKU heading and breadcrumb separator scenarios

Solution

Updated the test instructions and guidance content to:

  1. Clarify the distinction between semantic emphasis and visual styling
  2. Provide clear guidance that bold/italic used purely for design purposes does NOT require semantic markup
  3. Add new Pass/Fail examples demonstrating:
    • SKU Heading: Using <strong> inside a heading for visual styling is unnecessary since the heading already provides semantic importance
    • Breadcrumb Separator: Using <em> for italic separators is incorrect since they're for visual presentation, not emphasis

Comment thread src/assessments/semantics/test-steps/emphasis.tsx Outdated
Comment thread src/content/test/semantics/emphasis.tsx Outdated
Comment thread src/content/test/semantics/emphasis.tsx Outdated
Comment thread src/content/test/semantics/emphasis.tsx Outdated
@v-sohmondal
v-sohmondal marked this pull request as ready for review February 3, 2026 06:02
@v-sohmondal
v-sohmondal requested a review from a team as a code owner February 3, 2026 06:02
@v-jitendjain

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@v-jitendjain
v-jitendjain marked this pull request as draft July 6, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emphasis test leaves too little wiggle room

3 participants