fix: Implement Glasswing Mythos - August remediation - #7802
Merged
Bill Dengler (codeofdusk) merged 3 commits intoAug 19, 2026
Merged
fix: Implement Glasswing Mythos - August remediation#7802Bill Dengler (codeofdusk) merged 3 commits into
Bill Dengler (codeofdusk) merged 3 commits into
Conversation
v-jitendjain
changed the title
There was a problem hiding this comment.
Pull request overview
This PR remediates an HTML injection/XSS risk in the HTML issue-filing formatter by ensuring user-controlled link content is HTML-escaped before being interpolated into generated markup.
Changes:
- Escape
hrefbefore inserting it into the<a href="...">attribute. - Escape link visible text (and preserve the previous fallback behavior when
textis empty/undefined).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-jitendjain
changed the title
…asswingMythosRemediation
Contributor
Author
|
\azp run |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Bill Dengler (codeofdusk)
approved these changes
Aug 19, 2026
Rob Gallo (RobGallo)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
There is a Sev 25 ICM https://portal.microsofticm.com/imp/v5/incidents/details/850008679/summary which needs immediate attention.
Motivation
The defect is in link(), both the href and text are interpolated into HTML without escaping, unlike every other field in this formatter (snippet, howToFixSection, relatedPaths all use escape). This allows attacker-controlled values from document.title, document.URL, and result.selector to inject markup (CWE-79).
Context
• href is now escaped via escape(href) before being placed inside the href="..." attribute. This neutralizes characters like ", <, >, and & that could otherwise break out of the attribute context and inject arbitrary HTML/script.
• text is now escaped when provided (escape(text)), matching the treatment already given to snippets, related paths, and how-to-fix text in this same formatter.
• Fallback preserved: when text is empty, the escaped href is reused as the visible text, so behavior is unchanged for the non-malicious case.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.