Python: fix: reject service storage history conflict#5866
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
github-actions
Bot
changed the title
he-yufeng
force-pushed
the
fix/openai-store-history-provider
branch
from
116784b to
ee060f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5798.
Summary
require_per_service_call_history_persistence=Truewhen the effective chat options still use service-side history storagestore=Falseso the configuredHistoryProviderowns per-service-call persistenceTests
python -m py_compile python\packages\core\agent_framework\_agents.py python\packages\core\tests\core\test_agents.pyuv run ruff check packages\core\agent_framework\_agents.py packages\core\tests\core\test_agents.pyuv run pytest packages\core\tests\core\test_agents.py -q -k "per_service_call_persistence or service_storage_updates_session_handle" --basetemp .tmp\pytest -p no:cacheprovidergit diff --checkSelect-String -Path python\packages\core\agent_framework\_agents.py,python\packages\core\tests\core\test_agents.py -Pattern 'sk-[A-Za-z0-9_-]+'