Delegate sub-agent enablement to language server#349
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR delegates sub-agent enablement entirely to the Copilot language server by removing Eclipse-side gating (preferences/policy DTO/event plumbing) and always advertising the subAgent capability during LSP initialization, aligning the client with server-authoritative policy enforcement.
Changes:
- Add an ADR documenting why sub-agent enablement is server-governed and remove overlapping client-side mechanisms.
- Remove the sub-agent toggle and related UI preference plumbing, messages, and constants.
- Stop deserializing/propagating sub-agent policy in
policy/didChange, and always advertise sub-agent capability at init.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/adr/0001-sub-agent-enablement-is-server-governed.md | Adds an ADR capturing the rationale/decision to make sub-agent enablement server-authoritative. |
| CONTEXT.md | Introduces glossary terms clarifying “sub-agent”, “sub-agent policy”, and capability semantics. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/messages.properties | Removes UI strings for the sub-agent preference toggle. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/Messages.java | Removes the corresponding NLS fields for deleted sub-agent preference strings. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/CopilotPreferenceInitializer.java | Drops the default value initialization for the removed sub-agent preference key. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/ChatPreferencesPage.java | Removes the sub-agent toggle UI and related preference-driven tool configuration updates. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/policy/DidChangePolicyParams.java | Removes the sub-agent policy field and updates equals/hashCode/toString accordingly. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/LsStreamConnectionProvider.java | Always advertises subAgent capability as enabled during initialization. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageClient.java | Stops reacting to sub-agent policy changes from policy/didChange. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/FeatureFlags.java | Removes sub-agent policy state and preference-bridging logic. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/events/CopilotEventConstants.java | Removes the sub-agent policy change event topic constant. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/Constants.java | Removes the SUB_AGENT_ENABLED preference key constant. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #304