Accept FL/FD Infinity in Microsoft.Health.Dicom.Client metadata parse - #3533
Closed
Haywood CompuMed (HaywoodInPixels) wants to merge 1 commit into
Closed
Conversation
AHDS already emits ""-Infinity"" in DICOM JSON; bump fo-dicom to 5.2.6 and add an HttpMessageHandler repro so RetrieveStudyMetadataAsync no longer fails the whole study.
Haywood CompuMed (HaywoodInPixels)
requested a review
from a team
as a code owner
September 4, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.Health.Dicom.Client10.0.535 throwsMalformed DICOM json, number expectedwhen WADO-RS metadata contains an FL/FD value encoded as"-Infinity". Azure Health Data Services returns HTTP 200 with that string because JSON has no numeric infinity.This PR:
fo-dicom5.1.5→5.2.6so the client’sDicomJsonConverteraccepts"NaN"/"Infinity"/"-Infinity"HttpMessageHandlerrepro:RetrieveStudyMetadataAsyncagainst["-Infinity", -1]must parse, and a finite-value control caseRelated issues
Addresses #3532.
Testing
dotnet test src/Microsoft.Health.Dicom.Client.UnitTests/Microsoft.Health.Dicom.Client.UnitTests.csproj -p:Platform=x64— 2 passed.Please publish a new
Microsoft.Health.Dicom.Clientafter merge so 10.0.535 consumers can pick this up.