-
Notifications
You must be signed in to change notification settings - Fork 362
The Implementation for Bring Your Own Local Model (BYOM) API #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Selena Yang (selenayang888)
wants to merge
22
commits into
main
Choose a base branch
from
syang/bring-your-own-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
29a1bad
the implementation for BYOM
selenayang888 15e1dde
Add deep-copy semantics for ModelInfo
selenayang888 f1cb59a
Resolve conflicts
selenayang888 c1f1b8b
Fix the comment about "Deferred registrations"
selenayang888 0c6a729
fixed execution-provider override bug
selenayang888 a2dd9b2
Merge remote-tracking branch 'origin/main' into syang/bring-your-own-…
selenayang888 a1d7854
Addressed the comments
selenayang888 398f702
Added byom e2e test
selenayang888 75314ca
Guard config-derived EPs for BYOM model loads
selenayang888 37bfd13
Remove redundant GetLocalModels catalog API
selenayang888 46c523a
Merge remote-tracking branch 'origin/main' into syang/bring-your-own-…
selenayang888 db04e30
Removed the private catalog
selenayang888 fe1a713
Address high-confidence BYOM review feedback
selenayang888 49ae75c
Use one <alias>:<version> ID instead of separate values; Use filesize…
selenayang888 8843b9a
Extract reusable UTC timestamp utility
selenayang888 e3f0edb
Resolved several comments
selenayang888 43db1a0
resolve the comments
selenayang888 729e08a
Resolve "A constructed model should never have missing metadata"
selenayang888 49ecc8b
Name local model factory arguments
selenayang888 488aff7
Merge remote-tracking branch 'origin/main' into syang/bring-your-own-…
selenayang888 5591379
Fix BYOM catalog tests and Python API v2 bindings
selenayang888 5483fc9
Merge remote-tracking branch 'origin/main' into syang/bring-your-own-…
selenayang888 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "Deregister"
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We retained
UnregisterModel/UnregisterModelpair and precisely describes removing the catalog registration without deleting the model assets. If there is a project-wide naming convention requiringDeregisterModel, I can apply it consistently across the C and C++ APIs before merge.