Skip to content

deps: bump golang.org/x/net to v0.55.0 to fix GO-2026-5026#763

Merged
dlevy-msft-sql merged 1 commit into
microsoft:mainfrom
dlevy-msft-sql:deps/bump-x-net-0.55.0
May 27, 2026
Merged

deps: bump golang.org/x/net to v0.55.0 to fix GO-2026-5026#763
dlevy-msft-sql merged 1 commit into
microsoft:mainfrom
dlevy-msft-sql:deps/bump-x-net-0.55.0

Conversation

@dlevy-msft-sql
Copy link
Copy Markdown
Contributor

Problem

The Go Vulnerability Check workflow fails on PRs because govulncheck reports GO-2026-5026 against golang.org/x/net@v0.54.0:

Invoking failure to reject ASCII-only Punycode-encoded labels in golang.org/x/net/idna

Example trace from the failed run on #760:

internal/container/controller.go:216:28: container.Controller.ContainerFiles
  -> client.Client.ExecAttach
  -> idna.ToASCII

Root Cause

golang.org/x/net is an indirect dependency in go.mod. Dependabot's gomod ecosystem only proposes version bumps for modules listed as direct requirements; indirect deps move only when a direct dep's update transitively pulls them. The golang-x group on the recent dependabot PR (#760) therefore bumped golang.org/x/sys but left golang.org/x/net at the vulnerable v0.54.0.

The Go vuln database advisory (GO-2026-5026) also is not always mirrored to the GitHub Advisory Database, so Dependabot's security-update path didn't fire either.

Solution

Bump golang.org/x/net to v0.55.0 (the fixed version) and run go mod tidy. This also picks up the same golang.org/x/sys v0.45.0 bump proposed in #760, so this PR can supersede or land alongside it.

Changes

File Change
go.mod golang.org/x/net v0.54.0 -> v0.55.0 (indirect); golang.org/x/sys v0.44.0 -> v0.45.0
go.sum regenerated by go mod tidy

Testing

  • go build ./... passes locally.
  • CI's govulncheck ./... should now pass; expecting GO-2026-5026 to drop off.

Related

govulncheck flags GO-2026-5026 (idna.ToASCII fails to reject ASCII-only Punycode-encoded labels) on golang.org/x/net v0.54.0, reachable from internal/container/controller.go via docker client.ExecAttach. Fixed in v0.55.0.

Dependabot's golang-x group bumps direct deps only; x/net is indirect, so it was left behind.
@dlevy-msft-sql dlevy-msft-sql marked this pull request as ready for review May 27, 2026 00:24
@dlevy-msft-sql dlevy-msft-sql merged commit afe3e53 into microsoft:main May 27, 2026
6 checks passed
@dlevy-msft-sql dlevy-msft-sql deleted the deps/bump-x-net-0.55.0 branch May 27, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants