deps: bump golang.org/x/net to v0.55.0 to fix GO-2026-5026#763
Merged
dlevy-msft-sql merged 1 commit intoMay 27, 2026
Merged
Conversation
govulncheck flags GO-2026-5026 (idna.ToASCII fails to reject ASCII-only Punycode-encoded labels) on golang.org/x/net v0.54.0, reachable from internal/container/controller.go via docker client.ExecAttach. Fixed in v0.55.0. Dependabot's golang-x group bumps direct deps only; x/net is indirect, so it was left behind.
shueybubbles
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Go Vulnerability Checkworkflow fails on PRs because govulncheck reports GO-2026-5026 againstgolang.org/x/net@v0.54.0:Example trace from the failed run on #760:
Root Cause
golang.org/x/netis an indirect dependency ingo.mod. Dependabot'sgomodecosystem only proposes version bumps for modules listed as direct requirements; indirect deps move only when a direct dep's update transitively pulls them. Thegolang-xgroup on the recent dependabot PR (#760) therefore bumpedgolang.org/x/sysbut leftgolang.org/x/netat the vulnerable v0.54.0.The Go vuln database advisory (GO-2026-5026) also is not always mirrored to the GitHub Advisory Database, so Dependabot's security-update path didn't fire either.
Solution
Bump
golang.org/x/netto v0.55.0 (the fixed version) and rungo mod tidy. This also picks up the samegolang.org/x/sys v0.45.0bump proposed in #760, so this PR can supersede or land alongside it.Changes
go.modgolang.org/x/net v0.54.0->v0.55.0(indirect);golang.org/x/sys v0.44.0->v0.45.0go.sumgo mod tidyTesting
go build ./...passes locally.govulncheck ./...should now pass; expecting GO-2026-5026 to drop off.Related