deps: bump chroma to v2.25.0 and align devcontainer to Go 1.26#764
Open
dlevy-msft-sql wants to merge 2 commits into
Open
deps: bump chroma to v2.25.0 and align devcontainer to Go 1.26#764dlevy-msft-sql wants to merge 2 commits into
dlevy-msft-sql wants to merge 2 commits into
Conversation
chroma v2.25.0 raises the go directive in go.mod from 1.25.10 to 1.26 (and switches the indirect github.com/dlclark/regexp2 to v2). The check-go-version-alignment workflow then fails because .devcontainer/Dockerfile still pins go:1.25-bookworm. Bump the devcontainer base image to go:1.26-bookworm so the alignment check passes. Pinned Go tool versions (gopls 0.21.1, delve 1.26.1, staticcheck 0.7.0, gotext 0.35.0) are already compatible with Go 1.26. Supersedes microsoft#762.
go.mod now requires Go 1.26 (chroma v2.25.0 pulled it up). The lint and pr-validation workflows pin setup-go to 1.25.10 with GOTOOLCHAIN=local, so they fail with 'go.mod requires go >= 1.26'. Bump both to 1.26.0 to match.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #762 (dependabot bump of
github.com/alecthomas/chroma/v2from 2.24.1 to 2.25.0) fails the newcheck-go-version-alignmentjob:Root Cause
chroma v2.25.0's own
go.modrequires Go 1.26, which causesgo mod tidyto raise ourgodirective from1.25.10to1.26. The alignment workflow then catches that.devcontainer/Dockerfileis still pinned tomcr.microsoft.com/devcontainers/go:1.25-bookworm. Dependabot bumps deps but does not edit the Dockerfile, so the check stays red.Solution
Update
.devcontainer/Dockerfiletogo:1.26-bookwormalongside the chroma bump in a single PR, so bothgo.modand the devcontainer move together and the alignment check passes.The pinned Go tool versions in the Dockerfile (
gopls@v0.21.1,dlv@v1.26.1,staticcheck@v0.7.0,gotext@v0.35.0) are already compatible with Go 1.26, so no further changes are needed there.Changes
go.modgo 1.25.10->go 1.26;chroma/v2 2.24.1->2.25.0;dlclark/regexp2 v1.12.0->dlclark/regexp2/v2 v2.1.0(indirect)go.sum.devcontainer/Dockerfilego:1.25-bookworm->go:1.26-bookwormTesting
go build ./...passes locally with Go 1.26.0.check-go-version-alignmentjob should now pass (both sides report1.26).Related