fix(ui): keep base model selection consistent across training flows - #179
Merged
Marcelo (madpsys) merged 2 commits intoSep 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns base-model selection and filtering across UI training flows.
Changes:
- Adds catalog query, normalization, and selection helpers with regression tests.
- Restores selections from checkpoint URLs and safely handles null descriptions.
- Passes project event types and image-layer metadata from the Labeling Tool.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
BaseModelDropdown.jsx |
Uses normalized, controlled selections. |
BaseModelDropdownHelper.js |
Adds catalog and selection utilities. |
BaseModelDropdownHelper.test.js |
Tests helper behavior. |
CreateEditModelTrainingHelper.js |
Builds filtered catalog options. |
CreateEditModelTrainingModal.jsx |
Restores the selected base model. |
LabelingTool/LabelingTool.jsx |
Loads training filter metadata. |
LabelingTool/LabelingToolRightPanel.jsx |
Passes consistent training filters. |
LabelingTool/LeftPanel.jsx |
Removes obsolete panel. |
LabelingTool/RightPanel.jsx |
Removes obsolete panel. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Meygha Machado (mgmachado)
approved these changes
Aug 31, 2026
Marcelo (madpsys)
temporarily deployed
to
dev1
September 1, 2026 02:41 — with
GitHub Actions
Inactive
Marcelo (madpsys)
deleted the
v-marcelod/fix/model-catalog-dropdown-not-working
branch
September 1, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Base Model dropdown in the training form so that:
initialWeightsUrl.eventTypes=undefined.modelIdusebaseModelNameas a stable fallback key.This change also removes the unused legacy Labeling Tool panel components.
Fixes #
Type of change
Checklist
cd hastelib && hatch run test:pytest) and the UI lints clean (cd ui && npm run lint)Testing
The following validations were completed:
node --testnode --test src/Components/BaseModelDropdownHelper.test.jsnpm run buildgit diff --checkThe repository-wide UI lint still reports pre-existing errors unrelated to this change, so the combined Python/UI validation checklist remains unchecked.
Additional context
Training consumes
initialWeightsUrl, so the submitted training payload remains compatible with the existing backend contract.baseModelIdis maintained in UI state to control the dropdown and is resolved from the catalog checkpoint URL when editing an existing model.The authentication configuration for the Model Catalog routes was not changed. Those routes continue to use
AuthLevel.FUNCTION.