Skip to content

chore(ui): remove the imagery adjustment panel from View Results - #180

Open
Caleb Robinson (calebrob6) wants to merge 1 commit into
mainfrom
calebrob6/chore/remove-visualizer-imagery-controls
Open

chore(ui): remove the imagery adjustment panel from View Results#180
Caleb Robinson (calebrob6) wants to merge 1 commit into
mainfrom
calebrob6/chore/remove-visualizer-imagery-controls

Conversation

@calebrob6

Copy link
Copy Markdown
Member

Removes the opacity, contrast, hue rotation and saturation sliders from the View Results page, along with the state and the two handlers that only existed to feed them.

Split out of #136, which is where the request came from, so it can be reviewed on its own.

Why this is safe

The panel wrote straight to the Azure Maps layer options, and its reset button restored opacity: 1, contrast: 0, hueRotation: 0, saturation: 0. Those are the values the layers already start with, so removing the panel changes nothing about what the map draws.

getLayerById stays; it has other callers.

What is not touched

The labeling tool has its own separate copy of these sliders in LabelingToolLeftPanel.jsx. That is unaffected, which is also why the shared .labeling-imagery-controls CSS class stays.

Verification

209 deletions, no additions.

Check Result
UI tests (node --test) 94 passed
vite build exit 0
ESLint, repo-wide 240 problems, identical to main measured in the same container
ESLint, Visualizer.jsx 0 problems

No browser check. This repo has no Playwright config, so the page was verified by build and lint rather than by loading it.

The opacity, contrast, hue rotation and saturation sliders are gone from
the results page, along with the state and the two handlers that existed
only to feed them.

The panel wrote straight to the Azure Maps layer options and its reset
button restored opacity 1, contrast 0, hueRotation 0, saturation 0, which
are the values the layers already start with. Removing it therefore
changes nothing about what the map draws.

The labeling tool has its own separate copy of these sliders in
LabelingToolLeftPanel, which is untouched. The shared
.labeling-imagery-controls CSS class stays for that reason.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the imagery adjustment controls from View Results without affecting the labeling tool.

Changes:

  • Deletes the imagery controls component.
  • Removes its state, handlers, import, and rendering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
VisualizerImageryControls.jsx Removes the obsolete controls component.
Visualizer.jsx Removes associated wiring and state.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants