Skip to content

Switch layered to overlay filesystem - #1195

Open
Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 7 commits into
mainfrom
jayb/overlay-fs
Open

Switch layered to overlay filesystem#1195
Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 7 commits into
mainfrom
jayb/overlay-fs

Conversation

@jaybosamiya-ms

Copy link
Copy Markdown
Member

This PR removes the old layered file system, which had to deal with two different semantics with non-trivial complexity, instead to an overlay-based file system. This is aided by work I'd done to set up the ability to mount things (via the composer, #995), as well as a backend trait more amenable to the necessary composition (Backend, #887). With this PR, the last of the remaining layered file systems are removed.

@jaybosamiya-ms

Copy link
Copy Markdown
Member Author

As with many of my prior PRs, this PR is easiest to review one commit at a time :)

@github-actions

Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron

Failed in:
  enum litebox::fs::layered::LayeringSemantics, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/4a13b150b988bc40f65f7914a9d2aabd019f4549/litebox/src/fs/layered.rs:29
  enum litebox::fs::layered::MigrationError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/4a13b150b988bc40f65f7914a9d2aabd019f4549/litebox/src/fs/layered.rs:425

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron

Failed in:
  mod litebox::fs::layered, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/4a13b150b988bc40f65f7914a9d2aabd019f4549/litebox/src/fs/layered.rs:4

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron

Failed in:
  struct litebox::fs::layered::FileSystem, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/4a13b150b988bc40f65f7914a9d2aabd019f4549/litebox/src/fs/layered.rs:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant