remove non existing nodes when deploying cluster configuration#185
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cluster-configuration deployment script template to avoid failing during node labeling when the cluster configuration references nodes that are no longer present in the Kubernetes cluster.
Changes:
- Pre-fetches the current node list from the cluster and builds a set of “existing” nodes to gate labeling operations.
- Skips labeling for missing nodes and emits a warning to stderr when a configured node is not found.
- Refactors label command generation to use a
hostnametemplate variable for readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guozhongxin
approved these changes
Jun 24, 2026
zhogu
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove non existing nodes when deploying cluster configuration