netvsp: gdma driver report git commit on release 1.7.2511#3708
Open
erfrimod wants to merge 3 commits into
Open
netvsp: gdma driver report git commit on release 1.7.2511#3708erfrimod wants to merge 3 commits into
erfrimod wants to merge 3 commits into
Conversation
Soc needs a signal for determining what features are available. During triage, soc logs will provide more information to determine which version of the Gdma driver and OpenHCL was running. - OSVersionString1 set to "OpenHCL" - OSVersionString2 set to git commit - OPENHCL_VERSION split into 4 values and supplied to - OSVersionMajor - OSVersionMinor - OSVersionBuild - OSVersionPlatform
microsoft#3071) Follow-up to microsoft#2963 Some CI pipelines supply a zero for major version, causing build to fail. Removing the asserts that fail on `0` values. `OPENHCL_VERSION=0.8.175.0` ``` 133 | assert!(major != 0, "major version must be non-zero"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the failure occurred here ```
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
github-actions
Bot
added
release_1.7.2511
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cherry-picks changes to have the MANA/GDMA VF driver report OpenHCL identity (product + git revision) and a parsed OPENHCL_VERSION to the SOC via the existing GDMA_VERIFY_VF_DRIVER_VERSION request, improving field triage and feature-detection in logs for release 1.7.2511.
Changes:
- Populate
GdmaVerifyVerReqwithos_type,os_ver_{major,minor,build,platform}, andos_ver_str{1,2}(product name + git SHA) frombuild_info. - Log the reported driver identity/version on the HWC side when handling
GDMA_VERIFY_VF_DRIVER_VERSION. - Add compile-time parsing (and tests) for
OPENHCL_VERSIONinto 4 numeric components, allowing zero-valued components.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vm/devices/net/mana_driver/src/gdma_driver.rs | Sends OpenHCL identity + version fields to SOC in the verify-version request. |
| vm/devices/net/mana_driver/Cargo.toml | Adds build_info dependency to source version/product metadata. |
| vm/devices/net/gdma/src/hwc.rs | Logs VF driver identity/version fields received in verify-version requests. |
| vm/devices/net/gdma_defs/src/lib.rs | Adds OS_TYPE_OHCL constant used by the VF driver request. |
| openhcl/build_info/src/lib.rs | Adds const-time parsing of OPENHCL_VERSION into 4 u32 components plus unit tests. |
| Cargo.lock | Records the new build_info dependency for mana_driver. |
sunilmut
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry Picks of:
(#2963) | netvsp: gdma driver report git commit | 2943441
(#3071) | build_info: relax requirement that openhcl version... | 692483a
Cherry-pick was almost clean. Two exceptions: