fix: plugin root#364
Open
swatDong wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a skill-installation bug (issue #363) caused by a duplicated path prefix in the npx skills marketplace manifest. Previously, pluginRoot was ./.github/plugins while every plugin source entry already contained the full ./.github/plugins/... path, so the two were joined into a duplicated, non-existent path and plugin skills could not be detected. The change sets pluginRoot to ./, making it an effective no-op that leaves the already-complete source paths to resolve correctly from the repository root. This is functionally consistent with the sibling manifest .github/plugin/marketplace.json, which has no pluginRoot and also uses full source paths.
Changes:
- Change
pluginRootin.claude-plugin/marketplace.jsonfrom./.github/pluginsto./to eliminate the duplicated path prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the skill install issue (#363)
The plugin root/source was changed in (#148) and (#223), then has duplicated prefix
./.github/plugins, thus theskillscommand failed to detect those skills under plugins.This PR changes to
"pluginRoot": "./", which keepspluginRootfor compatibility and uses./as no-op.