Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows support for running test coverage via uv, aligning the developer workflow with the existing Unix make coverage target.
Changes:
- Added a
coveragecommand tomake.batthat runscoverage.pyviauv run. - Updated
.coveragercto measure coverage fromsrcinstead oftest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| make.bat | Adds a coverage target and updates the usage string to include it. |
| .coveragerc | Adjusts coverage source configuration to the src tree. |
Comment on lines
+50
to
+53
| uv run coverage erase | ||
| uv run coverage run -m pytest | ||
| uv run coverage combine | ||
| uv run coverage report |
There was a problem hiding this comment.
The Windows coverage target doesn't set COVERAGE_PROCESS_START. Some tests spawn the MCP server in a subprocess and only propagate COVERAGE_PROCESS_START if it’s already present, so coverage for subprocesses won’t be collected on Windows (unlike the Makefile target). Set COVERAGE_PROCESS_START=.coveragerc before coverage run (and optionally unset it afterwards) to match the Unix behavior.
Suggested change
| uv run coverage erase | |
| uv run coverage run -m pytest | |
| uv run coverage combine | |
| uv run coverage report | |
| uv run coverage erase | |
| set "COVERAGE_PROCESS_START=.coveragerc" | |
| uv run coverage run -m pytest | |
| uv run coverage combine | |
| uv run coverage report | |
| set "COVERAGE_PROCESS_START=" |
gvanrossum
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
fixed setup for uv coverage under Windows