Strip matching prefix in path mapping completions#4053
Open
gabritto wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the language service’s module-specifier/path-mapping completion logic where completion items could repeat already-typed path components (e.g. suggesting unstable/ast when completing under .../unstable/, leading to unstable/unstable/... after commit).
Changes:
- Strip the already-typed fragment directory prefix from path-mapping completion item names when the completion target already includes the fragment.
- Add fourslash regression tests covering partial-path completions for relative imports and package deep-imports (with and without
exports, including wildcard patterns).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/ls/string_completions.go | Adjusts path-mapping completion name shaping to trim the fragment directory prefix and avoid duplicated path components. |
| internal/fourslash/tests/pathCompletionsPartialPath_test.go | Adds regression tests verifying expected completion items for partial-path module specifiers across several scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3981.
Nice to notice Strada didn't have this problem because this scenario was just completely broken then. 😅