Skip to content

Merge latest Library.Template - #1498

Merged
AArnott merged 9 commits into
mainfrom
dev/andarno/libtemplateUpdate-20260729
Jul 29, 2026
Merged

Merge latest Library.Template#1498
AArnott merged 9 commits into
mainfrom
dev/andarno/libtemplateUpdate-20260729

Conversation

@AArnott

@AArnott AArnott commented Jul 29, 2026

Copy link
Copy Markdown
Member

Merges the latest Library.Template microbuild branch.

AArnott and others added 6 commits July 24, 2026 17:02
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This will avoid github API rate throttling for OSS repos that use nuget.org as their package feed.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…emplate

Specifically, this merges [5afbcaf from that repo](AArnott/Library.Template@5afbcaf).

# Conflicts:
#	Directory.Packages.props
Copilot AI review requested due to automatic review settings July 29, 2026 15:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs this repo with the latest Library.Template microbuild branch, updating shared build/test infrastructure so CI artifacts and documentation generation align with the template’s current expectations.

Changes:

  • Filter test artifact collection to avoid uploading crash/hang dump files except when they’re in the TRX attachment (In) directory.
  • Bump Microsoft Testing Platform package version to 2.3.3.
  • Update the docs GitHub Actions workflow to skip installing the NuGet credential provider during init.ps1.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tools/artifacts/testResults.ps1 Adds filtering around .dmp test artifacts (keep only those in TRX attachments).
Directory.Packages.props Updates centralized Microsoft Testing Platform version from 2.3.2 to 2.3.3.
.github/workflows/docs.yml Adjusts docs workflow prereq install to pass -NoNuGetCredProvider.
Comments suppressed due to low confidence (1)

tools/artifacts/testResults.ps1:21

  • Same issue as above: this regex only matches \\In\\ and will not match /In/ paths on non-Windows agents, unintentionally filtering out crash/hang dumps. Prefer a separator-agnostic regex and case-insensitive extension check.
        Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '\\In\\' }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/artifacts/testResults.ps1 Outdated
Copilot AI review requested due to automatic review settings July 29, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

tools/artifacts/testResults.ps1:21

  • Similar to the legacy TestResults block, Get-ChildItem $testlogsPath -Recurse returns directories as well as files, and the Where-Object filter will keep directories (they have an empty .Extension). These directories are later ignored by the staging script, but they still add unnecessary enumeration overhead and can mask the "No files found" warning. Limit this to files only.
    $result[$testlogsPath] = Get-ChildItem $testlogsPath -Recurse |
        Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '[/\\]In[/\\]' }

tools/artifacts/testResults.ps1:13

  • The current pipeline enumerates directories and then runs a recursive file search for each directory (Get-ChildItem ... -Recurse -Directory | Get-ChildItem -Recurse -File). With nested TestResults folders this repeats work and can return the same file multiple times (once per ancestor directory), which can slow artifact collection and cause redundant staging work. A single recursive file enumeration is sufficient.

This issue also appears on line 20 of the same file.

    $result[$testRoot] = Get-ChildItem $legacyTestResults -Recurse -Directory |
        Get-ChildItem -Recurse -File |
        Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '[/\\]In[/\\]' }

@AArnott
AArnott enabled auto-merge July 29, 2026 19:03
@AArnott
AArnott merged commit 0501fcd into main Jul 29, 2026
10 checks passed
@AArnott
AArnott deleted the dev/andarno/libtemplateUpdate-20260729 branch July 29, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants