Merge latest Library.Template - #1498
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This will avoid github API rate throttling for OSS repos that use nuget.org as their package feed.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…emplate Specifically, this merges [5afbcaf from that repo](AArnott/Library.Template@5afbcaf). # Conflicts: # Directory.Packages.props
There was a problem hiding this comment.
Pull request overview
This PR syncs this repo with the latest Library.Template microbuild branch, updating shared build/test infrastructure so CI artifacts and documentation generation align with the template’s current expectations.
Changes:
- Filter test artifact collection to avoid uploading crash/hang dump files except when they’re in the TRX attachment (
In) directory. - Bump Microsoft Testing Platform package version to
2.3.3. - Update the docs GitHub Actions workflow to skip installing the NuGet credential provider during
init.ps1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/artifacts/testResults.ps1 | Adds filtering around .dmp test artifacts (keep only those in TRX attachments). |
| Directory.Packages.props | Updates centralized Microsoft Testing Platform version from 2.3.2 to 2.3.3. |
| .github/workflows/docs.yml | Adjusts docs workflow prereq install to pass -NoNuGetCredProvider. |
Comments suppressed due to low confidence (1)
tools/artifacts/testResults.ps1:21
- Same issue as above: this regex only matches
\\In\\and will not match/In/paths on non-Windows agents, unintentionally filtering out crash/hang dumps. Prefer a separator-agnostic regex and case-insensitive extension check.
Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '\\In\\' }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…emplate Specifically, this merges [91b1441 from that repo](AArnott/Library.Template@91b1441).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tools/artifacts/testResults.ps1:21
- Similar to the legacy TestResults block,
Get-ChildItem $testlogsPath -Recursereturns directories as well as files, and theWhere-Objectfilter will keep directories (they have an empty.Extension). These directories are later ignored by the staging script, but they still add unnecessary enumeration overhead and can mask the "No files found" warning. Limit this to files only.
$result[$testlogsPath] = Get-ChildItem $testlogsPath -Recurse |
Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '[/\\]In[/\\]' }
tools/artifacts/testResults.ps1:13
- The current pipeline enumerates directories and then runs a recursive file search for each directory (
Get-ChildItem ... -Recurse -Directory | Get-ChildItem -Recurse -File). With nested TestResults folders this repeats work and can return the same file multiple times (once per ancestor directory), which can slow artifact collection and cause redundant staging work. A single recursive file enumeration is sufficient.
This issue also appears on line 20 of the same file.
$result[$testRoot] = Get-ChildItem $legacyTestResults -Recurse -Directory |
Get-ChildItem -Recurse -File |
Where-Object { $_.Extension -ne '.dmp' -or $_.FullName -match '[/\\]In[/\\]' }
AArnott
enabled auto-merge
July 29, 2026 19:03
sandyarmstrong
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the latest Library.Template microbuild branch.