chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.62.0 to 8.67.0 - #1921
chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.62.0 to 8.67.0#1921dependabot[bot] wants to merge 4 commits into
Conversation
dependabot
Bot
added
dependencies
|
Dependabot (@dependabot) rebase |
7ac996c to
c799fc6
Compare
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.62.0 to 8.67.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.67.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.67.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c799fc6 to
b83224c
Compare
|
Dependabot (@dependabot) rebase |
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
Align the parser with eslint-plugin v8 and replace rules removed or renamed across the v6-v8 migration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the typescript-eslint v8 migration is compatibility-complete and all current-head checks pass.
There was a problem hiding this comment.
🟡 Changes recommended
The dependency bump introduces version/engine compatibility concerns (ESLint peer minimum and Node engine requirements) that should be addressed to avoid install/CI issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repo’s TypeScript ESLint tooling to newer @typescript-eslint v8 packages and makes the corresponding ESLint config/source tweaks needed to keep linting green.
Changes:
- Bump
@typescript-eslint/eslint-pluginand@typescript-eslint/parserto^8.67.0. - Update
.eslintrc.jsto use v8 rule names and remove rules no longer supported. - Adjust a few TS sites (catch bindings, eslint-disable) to satisfy updated lint rules.
File summaries
| File | Description |
|---|---|
package.json |
Updates TypeScript ESLint devDependency versions. |
package-lock.json |
Refreshes the lockfile to the new dependency graph/version set. |
.eslintrc.js |
Renames/removes rules to match @typescript-eslint v8 behavior. |
src/utils/configUtils.ts |
Removes unused catch binding (lint-driven). |
src/runners/testngRunner/TestNGRunnerResultAnalyzer.ts |
Removes unused catch binding (lint-driven). |
src/experimentationService.ts |
Updates eslint-disable rule name for require. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
A newer version of @typescript-eslint/eslint-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Merge the latest main branch, align ESLint with the v8 peer range, address review feedback, and cover malformed TestNG output diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The dependency bump introduces transitive Node engine requirements (>=20 / ^20.19.0) that aren’t documented or pinned for contributors, risking install/lint failures outside CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
Declare and test the minimum Node version required by the upgraded lint dependency tree. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bumps @typescript-eslint/eslint-plugin from 5.62.0 to 8.67.0.
Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.
... (truncated)
Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.
... (truncated)
Commits
20a261fchore(release): publish 8.67.06dfe4d0chore(eslint-plugin-internal): [plugin-test-formatting] enforce zero-indentat...3b155bbchore: use typescript 7 for typechecking (#12601)e51b11bchore(release): publish 8.66.020cb15echore(eslint-plugin): split prefer-optional-chain.test.ts in multiple files (...780a8c5docs(eslint-plugin): [member-ordering] add lacking commas in default member t...08dd427fix(eslint-plugin): [class-literal-property-style] preserve type annotations ...6be25d3fix(eslint-plugin): [no-unnecessary-type-parameters] check MappedType key rem...8826d0efix(eslint-plugin): [no-useless-default-assignment] don't report defaults use...7aecc1cfix(eslint-plugin): [prefer-nullish-coalescing] handle shadowed Boolean calls...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@typescript-eslint/eslint-pluginsince your current version.