Skip to content

chore: onboard onto CFSClean - #326394

Draft
Raymond Zhao (rzhao271) wants to merge 7 commits into
mainfrom
rzhao271/onboard-cfs
Draft

chore: onboard onto CFSClean#326394
Raymond Zhao (rzhao271) wants to merge 7 commits into
mainfrom
rzhao271/onboard-cfs

Conversation

@rzhao271

@rzhao271 Raymond Zhao (rzhao271) commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=458022&view=results

The CFSClean policy restricts access to public feeds, so I also changed the auth setup steps to run even when there is a node_modules cache available.

Copilot AI review requested due to automatic review settings July 17, 2026 19:53
@rzhao271 Raymond Zhao (rzhao271) added this to the 1.130.0 milestone Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Onboards product builds onto CFSClean network isolation and ensures package authentication remains available on cache hits.

Changes:

  • Enables the CFSClean network isolation policy.
  • Runs npm authentication regardless of node_modules cache state.
  • Runs macOS PyPI authentication unconditionally.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
build/azure-pipelines/product-build.yml Enables CFSClean.
build/azure-pipelines/win32/product-build-win32-node-modules.yml Makes npm authentication unconditional on cache state.
build/azure-pipelines/web/product-build-web-node-modules.yml Makes npm authentication unconditional on cache state.
build/azure-pipelines/linux/product-build-linux-node-modules.yml Makes npm authentication unconditional on cache state.
build/azure-pipelines/darwin/product-build-darwin-node-modules.yml Makes npm and PyPI authentication unconditional on cache state.
build/azure-pipelines/alpine/product-build-alpine-node-modules.yml Makes npm authentication unconditional on cache state.

@rzhao271
Raymond Zhao (rzhao271) marked this pull request as ready for review July 22, 2026 21:31
@vs-code-engineering

vs-code-engineering Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/alpine/product-build-alpine-node-modules.yml
  • build/azure-pipelines/darwin/product-build-darwin-node-modules.yml
  • build/azure-pipelines/linux/product-build-linux-node-modules.yml
  • build/azure-pipelines/oss/scan-licenses.ts
  • build/azure-pipelines/product-build.yml
  • build/azure-pipelines/product-quality-checks.yml
  • build/azure-pipelines/web/product-build-web-node-modules.yml
  • build/azure-pipelines/win32/product-build-win32-node-modules.yml
  • build/azure-pipelines/win32/sdl-scan-win32.yml

@rzhao271
Raymond Zhao (rzhao271) marked this pull request as draft July 23, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants