windows-reactor-setup replace framework-dependent resources.pri#4562
windows-reactor-setup replace framework-dependent resources.pri#4562riverar wants to merge 1 commit into
windows-reactor-setup replace framework-dependent resources.pri#4562Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates windows-reactor-setup to embed and write a small dummy resources.pri during framework-dependent setup, instead of staging Microsoft.UI.pri from the Microsoft.WindowsAppSDK.InteractiveExperiences NuGet package. This keeps the required .pri file present for WinUI 1.8+ while reducing download/extract footprint until WindowsAppSDK PR #5828 is fixed.
Changes:
- Stop downloading/staging
Microsoft.WindowsAppSDK.InteractiveExperiencesjust to obtainMicrosoft.UI.pri. - Write an embedded
assets/resources.pritoresources.priin the target output directory. - Treat
*.prias binary in.gitattributesto avoid text conversions/diffs.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/libs/reactor-setup/src/lib.rs | Removes InteractiveExperiences staging and writes an embedded resources.pri directly. |
| .gitattributes | Marks *.pri as binary to preserve the embedded PRI file correctly in git. |
|
Please take a look at the idea with |
windows-reactor-setup replace framework-dependent resources.pri
|
That'll put us in the middle of all custom resource manager requests and increase the risk we mishandle legitimate requests right? What if the dev wants to specify their own resource manager for their needs? (The good news is we won't have to keep this code around for long. All signs are pointing to this getting fixed in the next Windows App SDK patch release.) |
|
Does |
windows-reactor-setupnow embeds a dummyresources.priinstead of staging it from the Microsoft.WindowsAppSDK.InteractiveExperiences NuGet package, reducing our on-disk footprint by ~100KiB and reducing our build time footprint by ~94MiB.The file must remain in place until microsoft/WindowsAppSDK#5828 is fixed.
Fixes #4546