windows-reactor remove unnecessary ops registry thread local#4567
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the windows-reactor attached-prop ops registry thread-local by moving clone/eq behavior into a trait-object vtable, reducing per-thread state and simplifying AttachedProps cloning/equality. Also updates the reactor internals documentation to reflect the removal and clarifies which remaining thread-locals are blocked by the current public free-function API surface.
Changes:
- Replaced
AttachedPropsstorage fromBox<dyn Any>+ TLS ops registry toBox<dyn AttachedValue>withclone_box/eq_boxin the vtable. - Removed
register_ops/ops_forand theOPS_REGISTRYthread_local!frommodifiers.rs. - Updated
docs/reactor-internals.mdto remove theOPS_REGISTRYentry and note why some TLS values are harder to eliminate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/reactor-internals.md | Removes OPS_REGISTRY from the thread-local inventory and updates optimization notes to match the new design. |
| crates/libs/reactor/src/core/modifiers.rs | Eliminates the OPS_REGISTRY thread-local by embedding clone/eq into a trait-object vtable for AttachedProps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.