[oadp-1.6] Default namespace to openshift-adp instead of velero#183
Conversation
When no VELERO_NAMESPACE env var or config file is present, the Velero library falls back to "velero" as the default namespace. Set it to "openshift-adp" in the root command when no namespace is configured. Guard against nil config map from LoadConfig errors. Remove unused CreateVeleroFactory and CreateNonAdminFactory functions from factories.go. Signed-off-by: Joseph <jvaikath@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, openshift-cherrypick-robot, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This is an automated cherry-pick of #182
/assign Joeavaikath