Skip to content

🎨 Palette: [UX improvement] Improve Settings folder list accessibility#421

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-ux-settings-18051238701319159522
Open

🎨 Palette: [UX improvement] Improve Settings folder list accessibility#421
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-ux-settings-18051238701319159522

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What: Move ToolTipService.ToolTip to the StackPanel and set its Background to Transparent.
🎯 Why: In WinUI, layout panels without a background are not hit-testable. The tooltip containing the folder path was previously only applied to the TextBlock, making the hover area tiny.
🧑‍🦽 Accessibility: Screen readers will now announce the path when focusing the container, and mouse users can easily discover the full path when hovering over any part of the folder item.


PR created automatically by Jules for task 18051238701319159522 started by @mikekthx

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@google-labs-jules google-labs-jules Bot requested a review from mikekthx as a code owner June 26, 2026 11:38
@github-actions github-actions Bot added the ui Front-end changes, WinUI layouts, styling (e.g., Acrylic), or system tray updates. label Jun 26, 2026
@mikekthx

Copy link
Copy Markdown
Owner

Code Review — PR #421

What this PR does: Moves ToolTipService.ToolTip from the inner path TextBlock to its parent StackPanel, and adds Background="Transparent" to the StackPanel so it participates in hit-testing. This expands the tooltip hover area from just the small truncated-path text to the entire folder item row.

Overall assessment: ✅ Correct and well-scoped. The fix is minimal and addresses a real UX deficiency.


What's right

  • Hit-testing fix is correct. In WinUI 3, layout panels without a Background are transparent to pointer events — the Background="Transparent" on the StackPanel is the canonical fix to make the element hittable.
  • {x:Bind Path} without a converter is safe here. SettingsWindow is a Window (not a FrameworkElement), and the known sharp edge (compile error "cannot convert from 'SettingsWindow' to 'FrameworkElement'") only applies when a Converter= is present in a DataTemplate rooted in a Window. This change has no converter, so it compiles cleanly.
  • No localization needed. The tooltip value is the raw Path string — a file-system path, not UI copy.
  • No service wiring, test changes, or Launchbox.Tests.csproj links needed. Pure XAML change with no new testable logic.
  • ShortcutFolder.Path is a non-nullable required string, so there is no null-tooltip risk.

Minor observations (non-blocking)

  • Tooltip on the Label TextBlock may surprise users. The label (e.g. "Work") has no TextTrimming, so it is always fully visible. A user hovering over it will now see the path tooltip even though the label text is not the thing being truncated. This is an accepted pattern for row-level tooltips and unlikely to be confusing in practice, but it is a behavioural change worth noting.
  • Screen reader claim is partially accurate. The PR body states screen readers will announce the path when focusing the container. In WinUI 3, ToolTipService.ToolTip populates AutomationProperties.HelpText (the accessible description), not AutomationProperties.Name. That is still an improvement over before, just not a full accessible-name announcement.

No blocking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Front-end changes, WinUI layouts, styling (e.g., Acrylic), or system tray updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant