Conversation
- Kotlin 2.4.10, Java target 17, CI Java 17 - MineVNLib, PlayerPoints, PlaceholderAPI, bStats - Đổi PlayerPoints về repo gốc
Contributor
📝 WalkthroughWalkthroughThe build targets Java 17 for compilation and Java 21 for toolchain resolution and CI. The Kotlin JVM plugin and plugin dependencies were updated. CI uploads only ChangesBuild modernization
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dotman-plugin/build.gradle.kts (1)
12-12: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winRestrict the Rosewood repository to PlayerPoints.
Line 12 adds a broad repository for one dependency. Scope it with
exclusiveContentto reduce dependency-confusion and repository-resolution risk.Suggested change
- maven("https://repo.rosewooddev.io/repository/public/") + exclusiveContent { + forRepository { + maven("https://repo.rosewooddev.io/repository/public/") + } + filter { + includeGroup("org.black_ixx") + } + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@dotman-plugin/build.gradle.kts` at line 12, Update the repository declaration in the Gradle configuration to wrap the Rosewood Maven repository in exclusiveContent, restricting its resolution scope to the PlayerPoints dependency while leaving other dependencies on their existing repositories.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@dotman-plugin/build.gradle.kts`:
- Line 12: Update the repository declaration in the Gradle configuration to wrap
the Rosewood Maven repository in exclusiveContent, restricting its resolution
scope to the PlayerPoints dependency while leaving other dependencies on their
existing repositories.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 388a0409-0533-4e43-883e-fb60a62550fc
📒 Files selected for processing (4)
.github/workflows/build.yml.github/workflows/release.ymlbuild.gradle.ktsdotman-plugin/build.gradle.kts
- Dùng JDK 21 toolchain để resolve Paper 1.21.11, giữ bytecode plugin Java 17 - Đổi API compile từ Spigot 1.20.4 sang Paper 1.21.11 - Thêm PaperMC Maven repository và bỏ Spigot snapshots repository
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s build configuration and plugin dependencies, aiming to modernize the build/tooling (Kotlin + Java target) and refresh key Bukkit/Paper ecosystem libraries.
Changes:
- Bumped Kotlin Gradle plugin version and updated Java compilation/target settings in the root Gradle build.
- Updated
dotman-plugindependencies (MineVNLib, PlayerPoints, PlaceholderAPI, bStats) and switched from Spigot API to Paper API. - Updated GitHub Actions build and release workflows to use Java 17.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dotman-plugin/build.gradle.kts |
Switches to Paper API and bumps plugin library dependencies and repositories. |
build.gradle.kts |
Updates Kotlin version and adjusts Java/Kotlin compilation and resolution settings. |
.github/workflows/build.yml |
Runs CI build with Java 17. |
.github/workflows/release.yml |
Runs release build with Java 17. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minhh2792
changed the title
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yml:
- Line 35: Update the upload-artifact step containing the DotMan.jar path to set
if-no-files-found to error, ensuring the workflow fails when shadowJar does not
produce the expected artifact.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b79dd970-0cd6-4fe0-995e-18e56a0a51a9
📒 Files selected for processing (2)
.github/workflows/build.yml.github/workflows/release.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
dotman-plugin/build.gradle.kts:23
- The PR description claims the plugin runs on MC 1.12.2+, but the build now compiles against Paper 1.21.11 API. Compiling against a much newer API makes it easy to accidentally use methods/classes that don’t exist on older servers, causing NoSuchMethodError/ClassNotFoundException at runtime. If 1.12.2 compatibility is still required, consider enforcing a minimal API baseline (e.g., compile against an older Spigot/Bukkit API and only use Paper-specific APIs behind reflection/guards) and document the supported server matrix.
dependencies {
// paper
compileOnly("io.papermc.paper:paper-api:1.21.11-R0.1-SNAPSHOT")
// libs
compileOnly("net.minevn:minevnlib-plugin:26.1.2")
compileOnly("org.black_ixx:playerpoints:3.3.5")
compileOnly("me.clip:placeholderapi:2.12.3")
implementation("org.bstats:bstats-bukkit:3.2.1")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sau khi test, plugin có thể chạy trên Java 17+, MC 1.12.2+
Summary by CodeRabbit