Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion miniflux.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def _get_endpoint(self, path: str) -> str:
return f"{self._base_url}/v{self.API_VERSION}{path}"

def _get_params(self, **kwargs) -> Optional[dict]:
params = {k: v for k, v in kwargs.items() if v}
params = {k: v for k, v in kwargs.items() if v is not None}
return params if len(params) > 0 else None

def _get_modification_params(self, **kwargs) -> dict:
Expand Down
24 changes: 23 additions & 1 deletion tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,29 @@ def test_get_entries_with_starred_param_at_false(self):

session.get.assert_called_once_with(
"http://localhost/v1/entries",
params={"after_entry_id": 123},
params={"starred": False, "after_entry_id": 123},
timeout=30,
)

assert result == expected_result

def test_get_entries_with_zero_offset(self):
session = requests.Session()
expected_result = []

response = mock.Mock()
response.status_code = 200
response.json.return_value = expected_result

session.get = mock.Mock()
session.get.return_value = response

client = miniflux.Client("http://localhost", "username", "password", session=session)
result = client.get_entries(offset=0, status="unread")

session.get.assert_called_once_with(
"http://localhost/v1/entries",
params={"offset": 0, "status": "unread"},
timeout=30,
)

Expand Down