Skip to content

fix(client): annotate _handle_error_response as NoReturn #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fguillot merged 1 commit into from
Mar 24, 2026
Merged

fix(client): annotate _handle_error_response as NoReturn #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions miniflux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

from typing import List, Optional, Union
from typing import List, NoReturn, Optional, Union

import requests

Expand Down Expand Up @@ -164,7 +164,7 @@ def _get_params(self, **kwargs) -> Optional[dict]:
def _get_modification_params(self, **kwargs) -> dict:
return {k: v for k, v in kwargs.items() if v is not None}

def _handle_error_response(self, response: requests.Response):
def _handle_error_response(self, response: requests.Response) -> NoReturn:
if response.status_code == 404:
raise ResourceNotFound(response)
if response.status_code == 403:
Expand Down