Handle multiple directories in SSL_CERT_DIR env variable#1697
Open
iiljkic wants to merge 3 commits intominio:masterfrom
Open
Handle multiple directories in SSL_CERT_DIR env variable#1697iiljkic wants to merge 3 commits intominio:masterfrom
iiljkic wants to merge 3 commits intominio:masterfrom
Conversation
balamurugana
requested changes
Apr 21, 2026
| ks.setCertificateEntry(namePrefix + (certsInFile++), cert); | ||
| } | ||
| return index; | ||
| return certsInFile; |
Member
There was a problem hiding this comment.
You are just renaming variables here. I don't think it is needed.
| } | ||
|
|
||
| private static X509TrustManager getTrustManagerFromDir(String dirPath) | ||
| private static X509TrustManager getTrustManagerFromDirs(String dirPaths) |
Member
There was a problem hiding this comment.
I don't think we need to say paths. Just treat dirPath like PATH env var i.e. colon separated list of path. This applicable everywhere.
Author
|
Reverted the renamings to keep the diff as small as possible |
balamurugana
requested changes
Apr 22, 2026
Author
|
I removed the Note: I assumed you meant to inline it inside |
balamurugana
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
SSL_CERT_DIRenvironment variable is treated as a single directory path. However, this variable often contains multiple paths separated by the OS path separator. See the OpenSSL manual:This PR updates the certificate loading logic to support multiple directories, ensuring broader compatibility with enterprise and containerized environments.
Changes Proposed
SSL_CERT_DIRstring is now split using the OS-specific path separator (File.pathSeparator).Testing Done
./gradlew :api:spotlessApply,./gradlew build, and./gradlew runFunctionalTestand confirmed everything still green.