Skip to content

Changed MDS to use private Repo #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bexsoft merged 4 commits into from
Aug 3, 2026
Merged

Changed MDS to use private Repo #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
718d203
web-app: switch mds dependency to git+ssh URL
Jul 29, 2026
44bed5a
bump ws resolution to ^8.21.1 for CVE-2026-62389 (#6)
astraios Jul 29, 2026
1695e50
Merge branch 'master' into mds-private-change
bexsoft Jul 29, 2026
718e43a
Merge branch 'master' into mds-private-change
bexsoft Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"local-storage-fallback": "^4.1.3",
"lodash": "^4.18.1",
"luxon": "^3.7.2",
"mds": "https://github.com/minio/mds.git#v1.1.5",
"mds": "git+ssh://git@github.com/minio/mds.git#v1.1.5",

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

GIT_SSH_COMMAND='ssh -o BatchMode=yes -o StrictHostKeyChecking=yes' \
  git ls-remote ssh://git@github.com/minio/mds.git refs/tags/v1.1.5

Repository: miniohq/object-browser

Length of output: 406

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- dependency declaration ---'
sed -n '1,30p' web-app/package.json

printf '%s\n' '--- lockfile references ---'
rg -n -C 3 'mds|400914d72cb3ffa27d600e0ae1f17ece2182ec22|v1\.1\.5|ws' \
  web-app/package-lock.json web-app/yarn.lock web-app/pnpm-lock.yaml 2>/dev/null || true

printf '%s\n' '--- HTTPS tag resolution ---'
git ls-remote https://github.com/minio/mds.git \
  refs/tags/v1.1.5 refs/tags/v1.1.5^{} || true

Repository: miniohq/object-browser

Length of output: 23950

Configure non-interactive SSH access for every install environment. Dependency resolution fails without a trusted github.com host key and read access to minio/mds; the lockfile does not provide either. Add a pinned known_hosts entry and deploy credentials, or use an authenticated HTTPS source.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web-app/package.json` at line 15, Update the mds dependency declaration
associated with the "mds" package entry to use an authenticated HTTPS source, or
configure the install environment with a pinned github.com known_hosts entry and
read credentials for minio/mds. Ensure dependency installation works
non-interactively in every supported environment.

"react": "^18.3.1",
"react-copy-to-clipboard": "^5.1.1",
"react-dom": "^18.3.1",
Expand Down Expand Up @@ -94,7 +94,7 @@
"postcss": "^8.4.38",
"fast-xml-parser": "^4.5.0",
"semver": "^7.5.2",
"ws": "^8.17.1",
"ws": "^8.21.1",
"rollup": "^4.24.0",
"cookie": "^0.7.2",
"jspdf": "^3.0.0",
Expand Down
14 changes: 7 additions & 7 deletions web-app/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11477,9 +11477,9 @@ __metadata:
languageName: node
linkType: hard

"mds@https://github.com/minio/mds.git#v1.1.5":
"mds@git+ssh://git@github.com/minio/mds.git#v1.1.5":
version: 1.1.5
resolution: "mds@https://github.com/minio/mds.git#commit=400914d72cb3ffa27d600e0ae1f17ece2182ec22"
resolution: "mds@git+ssh://git@github.com/minio/mds.git#commit=400914d72cb3ffa27d600e0ae1f17ece2182ec22"
dependencies:
"@types/styled-components": "npm:^5.1.34"
"@uiw/react-textarea-code-editor": "npm:^3.1.1"
Expand Down Expand Up @@ -17990,7 +17990,7 @@ __metadata:
local-storage-fallback: "npm:^4.1.3"
lodash: "npm:^4.18.1"
luxon: "npm:^3.7.2"
mds: "https://github.com/minio/mds.git#v1.1.5"
mds: "git+ssh://git@github.com/minio/mds.git#v1.1.5"
minio: "npm:^8.0.7"
nyc: "npm:^15.1.0"
prettier: "npm:3.8.3"
Expand Down Expand Up @@ -18644,9 +18644,9 @@ __metadata:
languageName: node
linkType: hard

"ws@npm:^8.17.1":
version: 8.20.0
resolution: "ws@npm:8.20.0"
"ws@npm:^8.21.1":
version: 8.21.1
resolution: "ws@npm:8.21.1"
peerDependencies:
bufferutil: ^4.0.1
utf-8-validate: ">=5.0.2"
Expand All @@ -18655,7 +18655,7 @@ __metadata:
optional: true
utf-8-validate:
optional: true
checksum: 10c0/956ac5f11738c914089b65878b9223692ace77337ba55379ae68e1ecbeae9b47a0c6eb9403688f609999a58c80d83d99865fe0029b229d308b08c1ef93d4ea14
checksum: 10c0/c4c6f1d95f6d465262de2037c57c715725d67e078dd49420ede4e19115668aba159cb64d85c5e89c06eb2826be599e62e5095860ad6cc54ff42e8bd7684e1db8
languageName: node
linkType: hard

Expand Down
Loading