Skip to content

build(bpmn): adopt central @miragon/bpmnlint-plugin-rules #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emaarco merged 2 commits into from
Aug 20, 2026
Merged

build(bpmn): adopt central @miragon/bpmnlint-plugin-rules #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb75c5
build(bpmn): adopt central @miragon/bpmnlint-plugin-rules as a blocki…
emaarco Aug 20, 2026
57d9eaf
refactor(bpmn): conform both models to @miragon/rules/all
emaarco Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
457 changes: 237 additions & 220 deletions .../app/src/main/kotlin/io/miragon/blueprint/adapter/process/BikeLeasingProcessProcessApi.kt
View file
Open in desktop

Large diffs are not rendered by default.

60 changes: 30 additions & 30 deletions ...ice/app/src/main/kotlin/io/miragon/blueprint/adapter/process/CancelBikeOrderProcessApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,50 +74,50 @@ object CancelBikeOrderProcessApi {
* Worker code typically does not need these.
*/
object Flows {
val FLOW_0510_WB_5: BpmnFlow = BpmnFlow(
id = "Flow_0510wb5",
sourceRef = "startEvent_cancellationRequired",
targetRef = "serviceTask_requestCancellation",
)

val FLOW_0_GKP_33_W: BpmnFlow = BpmnFlow(
id = "Flow_0gkp33w",
sourceRef = "userTask_clarifyReturn",
targetRef = "serviceTask_bookCosts",
)

val FLOW_0_TC_4_YFK: BpmnFlow = BpmnFlow(
id = "Flow_0tc4yfk",
sourceRef = "serviceTask_requestCancellation",
targetRef = "gateway_cancellationPossible",
)

val FLOW_0_W_76_X_5_F: BpmnFlow = BpmnFlow(
id = "Flow_0w76x5f",
sourceRef = "gateway_join",
targetRef = "endEvent_orderReversed",
val FLOW_BOOK_COSTS_TO_JOIN: BpmnFlow = BpmnFlow(
id = "flow_bookCostsToJoin",
sourceRef = "serviceTask_bookCosts",
targetRef = "gateway_join",
)

val FLOW_1_A_0_G_4_V_1: BpmnFlow = BpmnFlow(
id = "Flow_1a0g4v1",
val FLOW_CANCELLATION_NOT_POSSIBLE: BpmnFlow = BpmnFlow(
id = "flow_cancellationNotPossible",
name = "No",
sourceRef = "gateway_cancellationPossible",
targetRef = "userTask_clarifyReturn",
condition = $$"""${cancellationPossible}""",
)

val FLOW_1_E_8_KS_1_K: BpmnFlow = BpmnFlow(
id = "Flow_1e8ks1k",
val FLOW_CANCELLATION_POSSIBLE: BpmnFlow = BpmnFlow(
id = "flow_cancellationPossible",
name = "Yes",
sourceRef = "gateway_cancellationPossible",
targetRef = "gateway_join",
isDefault = true,
)

val FLOW_1_V_5_TEJ_2: BpmnFlow = BpmnFlow(
id = "Flow_1v5tej2",
sourceRef = "serviceTask_bookCosts",
targetRef = "gateway_join",
val FLOW_CLARIFY_TO_BOOK_COSTS: BpmnFlow = BpmnFlow(
id = "flow_clarifyToBookCosts",
sourceRef = "userTask_clarifyReturn",
targetRef = "serviceTask_bookCosts",
)

val FLOW_JOIN_TO_REVERSED: BpmnFlow = BpmnFlow(
id = "flow_joinToReversed",
sourceRef = "gateway_join",
targetRef = "endEvent_orderReversed",
)

val FLOW_REQUEST_TO_POSSIBLE_GATEWAY: BpmnFlow = BpmnFlow(
id = "flow_requestToPossibleGateway",
sourceRef = "serviceTask_requestCancellation",
targetRef = "gateway_cancellationPossible",
)

val FLOW_REQUIRED_TO_REQUEST: BpmnFlow = BpmnFlow(
id = "flow_requiredToRequest",
sourceRef = "startEvent_cancellationRequired",
targetRef = "serviceTask_requestCancellation",
)
}

Expand Down
327 changes: 171 additions & 156 deletions service/app/src/main/resources/bpmn/bike-leasing.bpmn
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 29 additions & 29 deletions service/app/src/main/resources/bpmn/cancel-bike-order.bpmn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,38 +8,38 @@
<camunda:property name="additionalInputVariables" value="orderId, bikeId" />
</camunda:properties>
</bpmn:extensionElements>
<bpmn:outgoing>Flow_0510wb5</bpmn:outgoing>
<bpmn:outgoing>flow_requiredToRequest</bpmn:outgoing>
</bpmn:startEvent>
<bpmn:sequenceFlow id="Flow_0510wb5" sourceRef="startEvent_cancellationRequired" targetRef="serviceTask_requestCancellation" />
<bpmn:exclusiveGateway id="gateway_cancellationPossible" name="Cancellation possible?" default="Flow_1e8ks1k">
<bpmn:incoming>Flow_0tc4yfk</bpmn:incoming>
<bpmn:outgoing>Flow_1a0g4v1</bpmn:outgoing>
<bpmn:outgoing>Flow_1e8ks1k</bpmn:outgoing>
<bpmn:sequenceFlow id="flow_requiredToRequest" sourceRef="startEvent_cancellationRequired" targetRef="serviceTask_requestCancellation" />
<bpmn:exclusiveGateway id="gateway_cancellationPossible" name="Cancellation possible?" default="flow_cancellationPossible">
<bpmn:incoming>flow_requestToPossibleGateway</bpmn:incoming>
<bpmn:outgoing>flow_cancellationNotPossible</bpmn:outgoing>
<bpmn:outgoing>flow_cancellationPossible</bpmn:outgoing>
</bpmn:exclusiveGateway>
<bpmn:sequenceFlow id="Flow_0tc4yfk" sourceRef="serviceTask_requestCancellation" targetRef="gateway_cancellationPossible" />
<bpmn:sequenceFlow id="Flow_1a0g4v1" name="No" sourceRef="gateway_cancellationPossible" targetRef="userTask_clarifyReturn">
<bpmn:sequenceFlow id="flow_requestToPossibleGateway" sourceRef="serviceTask_requestCancellation" targetRef="gateway_cancellationPossible" />
<bpmn:sequenceFlow id="flow_cancellationNotPossible" name="No" sourceRef="gateway_cancellationPossible" targetRef="userTask_clarifyReturn">
<bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">${cancellationPossible}</bpmn:conditionExpression>
</bpmn:sequenceFlow>
<bpmn:endEvent id="endEvent_orderReversed" name="Order reversed">
<bpmn:incoming>Flow_0w76x5f</bpmn:incoming>
<bpmn:incoming>flow_joinToReversed</bpmn:incoming>
</bpmn:endEvent>
<bpmn:sequenceFlow id="Flow_1e8ks1k" name="Yes" sourceRef="gateway_cancellationPossible" targetRef="gateway_join" />
<bpmn:sequenceFlow id="flow_cancellationPossible" name="Yes" sourceRef="gateway_cancellationPossible" targetRef="gateway_join" />
<bpmn:userTask id="userTask_clarifyReturn" name="Clarify return with supplier" camunda:asyncAfter="true" camunda:formRef="clarifyReturnForm" camunda:formRefBinding="deployment">
<bpmn:documentation>Kept deliberately as a FORM-ONLY task to show the trade-off. It is completed straight through its Camunda Form (Tasklist) or the engine REST API, so the completion never passes through our domain services: any data entered on the form lands only in process variables and never reaches the domain model. In other words, for capturing business data this is NOT best practice. Contrast this with "Clarify alternative with customer" in bike-leasing.bpmn, which offers a domain REST endpoint (POST /api/bike-leasing/{id}/clarify-alternative) that updates the aggregate before completing the task.</bpmn:documentation>
<bpmn:incoming>Flow_1a0g4v1</bpmn:incoming>
<bpmn:outgoing>Flow_0gkp33w</bpmn:outgoing>
<bpmn:incoming>flow_cancellationNotPossible</bpmn:incoming>
<bpmn:outgoing>flow_clarifyToBookCosts</bpmn:outgoing>
</bpmn:userTask>
<bpmn:sequenceFlow id="Flow_0gkp33w" sourceRef="userTask_clarifyReturn" targetRef="serviceTask_bookCosts" />
<bpmn:sequenceFlow id="flow_clarifyToBookCosts" sourceRef="userTask_clarifyReturn" targetRef="serviceTask_bookCosts" />
<bpmn:exclusiveGateway id="gateway_join">
<bpmn:incoming>Flow_1e8ks1k</bpmn:incoming>
<bpmn:incoming>Flow_1v5tej2</bpmn:incoming>
<bpmn:outgoing>Flow_0w76x5f</bpmn:outgoing>
<bpmn:incoming>flow_cancellationPossible</bpmn:incoming>
<bpmn:incoming>flow_bookCostsToJoin</bpmn:incoming>
<bpmn:outgoing>flow_joinToReversed</bpmn:outgoing>
</bpmn:exclusiveGateway>
<bpmn:sequenceFlow id="Flow_0w76x5f" sourceRef="gateway_join" targetRef="endEvent_orderReversed" />
<bpmn:sequenceFlow id="Flow_1v5tej2" sourceRef="serviceTask_bookCosts" targetRef="gateway_join" />
<bpmn:sequenceFlow id="flow_joinToReversed" sourceRef="gateway_join" targetRef="endEvent_orderReversed" />
<bpmn:sequenceFlow id="flow_bookCostsToJoin" sourceRef="serviceTask_bookCosts" targetRef="gateway_join" />
<bpmn:serviceTask id="serviceTask_bookCosts" name="Book costs" camunda:asyncAfter="true" camunda:delegateExpression="#{bookCostsDelegate}">
<bpmn:incoming>Flow_0gkp33w</bpmn:incoming>
<bpmn:outgoing>Flow_1v5tej2</bpmn:outgoing>
<bpmn:incoming>flow_clarifyToBookCosts</bpmn:incoming>
<bpmn:outgoing>flow_bookCostsToJoin</bpmn:outgoing>
</bpmn:serviceTask>
<bpmn:serviceTask id="serviceTask_requestCancellation" name="Request cancellation" camunda:asyncAfter="true" camunda:delegateExpression="#{requestCancellationDelegate}">
<bpmn:extensionElements>
Expand All @@ -48,8 +48,8 @@
<camunda:property name="additionalOutputVariables" value="cancellationPossible" />
</camunda:properties>
</bpmn:extensionElements>
<bpmn:incoming>Flow_0510wb5</bpmn:incoming>
<bpmn:outgoing>Flow_0tc4yfk</bpmn:outgoing>
<bpmn:incoming>flow_requiredToRequest</bpmn:incoming>
<bpmn:outgoing>flow_requestToPossibleGateway</bpmn:outgoing>
</bpmn:serviceTask>
</bpmn:process>
<bpmndi:BPMNDiagram id="BPMNDiagram_1">
Expand Down Expand Up @@ -86,38 +86,38 @@
<dc:Bounds x="250" y="60" width="100" height="80" />
<bpmndi:BPMNLabel />
</bpmndi:BPMNShape>
<bpmndi:BPMNEdge id="Flow_0510wb5_di" bpmnElement="Flow_0510wb5">
<bpmndi:BPMNEdge id="Flow_0510wb5_di" bpmnElement="flow_requiredToRequest">
<di:waypoint x="208" y="100" />
<di:waypoint x="250" y="100" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_0tc4yfk_di" bpmnElement="Flow_0tc4yfk">
<bpmndi:BPMNEdge id="Flow_0tc4yfk_di" bpmnElement="flow_requestToPossibleGateway">
<di:waypoint x="350" y="100" />
<di:waypoint x="395" y="100" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1a0g4v1_di" bpmnElement="Flow_1a0g4v1">
<bpmndi:BPMNEdge id="Flow_1a0g4v1_di" bpmnElement="flow_cancellationNotPossible">
<di:waypoint x="420" y="125" />
<di:waypoint x="420" y="200" />
<di:waypoint x="480" y="200" />
<bpmndi:BPMNLabel>
<dc:Bounds x="432" y="153" width="15" height="14" />
</bpmndi:BPMNLabel>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1e8ks1k_di" bpmnElement="Flow_1e8ks1k">
<bpmndi:BPMNEdge id="Flow_1e8ks1k_di" bpmnElement="flow_cancellationPossible">
<di:waypoint x="445" y="100" />
<di:waypoint x="755" y="100" />
<bpmndi:BPMNLabel>
<dc:Bounds x="591" y="82" width="18" height="14" />
</bpmndi:BPMNLabel>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_0gkp33w_di" bpmnElement="Flow_0gkp33w">
<bpmndi:BPMNEdge id="Flow_0gkp33w_di" bpmnElement="flow_clarifyToBookCosts">
<di:waypoint x="580" y="200" />
<di:waypoint x="620" y="200" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_0w76x5f_di" bpmnElement="Flow_0w76x5f">
<bpmndi:BPMNEdge id="Flow_0w76x5f_di" bpmnElement="flow_joinToReversed">
<di:waypoint x="805" y="100" />
<di:waypoint x="852" y="100" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1v5tej2_di" bpmnElement="Flow_1v5tej2">
<bpmndi:BPMNEdge id="Flow_1v5tej2_di" bpmnElement="flow_bookCostsToJoin">
<di:waypoint x="720" y="200" />
<di:waypoint x="780" y="200" />
<di:waypoint x="780" y="125" />
Expand Down
2 changes: 1 addition & 1 deletion service/app/src/test/kotlin/io/miragon/blueprint/process/BikeLeasingProcessTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class BikeLeasingProcessTest {
.isEnded
.hasPassed(
Elements.EVENT_SIGNATURE_DEADLINE.value,
Elements.BOUNDARY_CONTRACT_NOT_SIGNED.value,
Elements.EVENT_CONTRACT_NOT_SIGNED.value,
Elements.SERVICE_TASK_SEND_REJECTION.value,
Elements.END_EVENT_APPLICATION_REJECTED.value,
)
Expand Down
9 changes: 8 additions & 1 deletion tools/.bpmnlintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
{
"extends": "bpmnlint:recommended"
"extends": [
"bpmnlint:recommended",
"plugin:camunda-compat/camunda-platform-7-24",
"plugin:@miragon/rules/all"
],
"moddleExtensions": {
"camunda": "camunda-bpmn-moddle/resources/camunda.json"
}
}
Loading
Loading