Fix README Installation: document mitre/atomic, not the AtomicCaldera fork#64
Merged
Merged
Conversation
…cCaldera fork The README's Installation/Dependencies steps described the third-party xenoscr/atomiccaldera project rather than this plugin. Every step was inaccurate for mitre/atomic: - Cloned xenoscr/atomiccaldera (and added `atomiccaldera` to plugins) instead of mitre/atomic / `atomic`. - `pip install -r requirements.txt` — no requirements file exists in this repo. - Manual `git clone redcanaryco/atomic-red-team` — the plugin clones this automatically on first enable (app/atomic_svc.py:clone_atomic_red_team_repo). - `git clone mitre/cti` + STIX2 dependency — never used; the technique/tactic mapping is read from enterprise-attack.json bundled inside the atomic-red-team repo (app/atomic_svc.py:111). - `edit conf/artconf.yml` — no conf/ directory or artconf reference exists in the code. Rewrites Installation to the standard CALDERA plugin flow (clone into plugins/, enable in local.yml, restart; data is auto-fetched) and trims Dependencies to what is actually required. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…tion-instructions # Conflicts: # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README's recent rewrite (2026-04-27 → 04-30) reintroduced setup instructions for the old third-party
xenoscr/atomiccalderaproject rather than this plugin (mitre/atomic). Every step in the Installation/Dependencies sections was inaccurate. Verified against the actual code:mitre/atomicxenoscr/atomiccaldera, addatomiccalderato pluginsmitre/atomic→plugins/atomic, enableatomicpip install -r requirements.txtrequirements.txtexists in the repogit clone redcanaryco/atomic-red-teamclone_atomic_red_team_repo()(app/atomic_svc.py:42-52)git clone mitre/cti+ STIX2 depenterprise-attack.jsonis bundled inside the atomic-red-team repo and read directly (app/atomic_svc.py:111).stix2is never importededit conf/artconf.ymlconf/dir, noartconfreference anywhere in codeChange
plugins/, enable inconf/local.yml, restart — data is auto-fetched on first load.giton PATH; Python deps from CALDERA core).Validation
grep -rni artconf→ only the README; noconf/directory.grep -rni mitre/cti / cti.git→ only the README; code reads bundledenterprise-attack.json.enterprise-attack.jsonconfirmed present inredcanaryco/atomic-red-team/atomic_red_team/(46 MB).stix2not imported anywhere; norequirements.txtin the repo.🤖 Generated with Claude Code