Revert README to accurate auto-clone docs (undo stale AtomicCaldera setup steps)#65
Merged
Merged
Conversation
PR #59 (mitre/atomicreadme) replaced the accurate auto-clone plugin docs with the obsolete AtomicCaldera (xenoscr/atomiccaldera) manual setup steps — clone atomiccaldera, clone mitre/cti, edit conf/artconf.yml, add atomiccaldera to plugins. None of that applies to this plugin: it auto-clones atomic-red-team into data/ on first enable() and reads the enterprise-attack.json bundled inside the ART repo for technique→tactic mapping. There is no conf/artconf.yml, no separate CTI clone, and the plugin name is `atomic` not `atomiccaldera`. Restores README.md from b909588 (the version every other Caldera checkout still pins), keeping the AtomicCaldera credit in Acknowledgements. Plugin code (tox CI fixes etc. from later commits) is unchanged — only the docs revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts
README.mdto the pre-#59 version (commitb909588).Why
PR #59 (
atomicreadme) replaced the accurate plugin docs with theobsolete AtomicCaldera (xenoscr/atomiccaldera) manual-setup
instructions — clone atomiccaldera, clone mitre/cti, edit
conf/artconf.yml, addatomiccalderato the plugins list.None of that applies to this plugin:
atomic, notatomiccaldera.data/atomic-red-teamonfirst
enable()(seeatomic_svc.clone_atomic_red_team_repo).enterprise-attack.jsonbundled inside the ART repo(
data/atomic-red-team/atomic_red_team/enterprise-attack.json) forthe technique→tactic mapping — no separate
mitre/cticlone.conf/artconf.yml; the code never reads such a file.Scope
Docs-only. Restores the README every other Caldera checkout still
pins, keeping the AtomicCaldera credit in Acknowledgements. No code
changes — the tox/CI fixes and other work that landed after #59 are
untouched.