Fix tests/run.py stuck in macOS CI - #4410
Merged
Merged
Conversation
zcbenz
changed the title
Contributor
|
This is a deadlock happening afterward because mx.clear_streams() holds the GIL while synchronously waiting for Metal callbacks that may need the GIL to release Python-owned DLPack data. Changing unittest invocation or runner size only masks the timing bug... I cannot even open a PR because now max one PR at a time... |
Member
Author
|
@aleroot Thanks for looking into this and sorry for the inconvenience, you should be able to open the new PR as a draft, or make the currently open one draft before opening a new one. We added some rules to avoid getting flooded by PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm out of idea why it is stuck in macOS CI and I can not reproduce locally :(
Switch back to
python -m unittest discover -v python/testsfor macOS CI for now before I figure out