docs: record why the reviewer registry could not be copied - #409
Conversation
The registry names who reviews and what their output looks like, but not the API surface it gets matched against — and GitHub exposes a PR's discussion through three. `gh pr list --json comments` returns only issue comments; CodeRabbit's findings here live in reviews[]. Registering the review's own text would have produced a permanently empty queue on a repository that was being reviewed the whole time. Fails toward 'no reviewer output yet', which is also what a quiet PR looks like — same family as lessons 087 and 094.
|
@coderabbitai review |
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review triageCI: all 6 check runs green ( Review: none ran. "Review limit reached", commit status Findings: none to dispose of. Explicit review requested and it did not help. Filed as #410 — hive runs one autonomous reviewer where dotfiles runs two, and Content: docs only, one lesson file plus its index row. Every wikilink verified to resolve against the working tree. Recommendation: merge on the human's call with the unreviewed status on the record, or hold until #410 lands if you would rather the lesson about review machinery be the first thing a second reviewer reads. |
|
Your plan includes PR reviews subject to rate limits. Reviews are available now. |
🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.0...v4.2.0) (2026-08-25) ### Features * add the reviewer registry that makes the triage queue answerable ([#407](#407)) ([2492151](2492151)) ### Bug Fixes * **spec:** record measured evidence on HIVE-384, and stop AC5 reading green ([#408](#408)) ([5fd5aa6](5fd5aa6)) ### Documentation * correct lesson-094's premise and three reviewer findings from [#401](#401) ([#406](#406)) ([66dbf17](66dbf17)) * record five lessons from the delegate-verb work ([#401](#401)) ([8bc66eb](8bc66eb)) * record why the reviewer registry could not be copied ([#409](#409)) ([2b920ba](2b920ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Lesson 096, from the #403 / #407 work. It merged before this was written; this carries the part worth keeping.
The finding
dotf pr triage-queuecallsgh pr list --json comments. GitHub exposes a PR's discussion through three separate surfaces — issue comments, the reviews API (reviews[]), and inline review comments — and that call returns only the first.On this repo CodeRabbit files proper reviews. #401's five findings live in
reviews[]as**Actionable comments posted: 5**;commentsheld only the walkthrough. So registering the review's own text as the marker would have produced a queue that was permanently, silently empty on a repository that was being reviewed the whole time.The dotfiles registry does not hit this because its second reviewer, PR-Agent, publishes through the comments API — which is why its marker does not transfer, and why "port the config" was the wrong mental model for #403.
Why it is worth a lesson rather than a commit message
The direction of failure. A wrong marker does not error — it returns "no reviewer output yet", which is also what a genuinely quiet PR looks like. Same family as 087 and 094: a check that cannot see its subject reports the subject is fine.
Two rules fall out:
gh api repos/…/pulls/N/reviewsversus…/issues/N/commentssettles it in ten seconds; reading the source registry for an hour does not.Docs only. All wikilinks verified against the working tree.