Update discovery to optionally allow dynamic builds#670
Merged
Conversation
Signed-off-by: Marek Kubica <marek@tarides.com>
djs55
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small clean-up of the
discover.exemechanism which generates build flags.dynamicwhich disables the-ccopt static. This makes it easier to build on platforms without a static configuration (my Fedora Linux complains that there's no static-lmfor example but is plenty happy to build a dynamic executable). The default is still to build a static executable, so nothing changes unless the user specifically requests--profile dynamicfrom Dune.OCAMLCvariable. The program didn't use it.cc @djs55