Remove useless condition in example#339
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom May 9, 2026
Merged
Conversation
## Motivation and Context The example files `examples/http_client.rb` and `examples/streamable_http_client.rb` are intended to be run as standalone scripts and are not designed to be reused as modules (e.g., via `require`). The `if __FILE__ == $PROGRAM_NAME` guard therefore serves no purpose and is removed. ## How Has This Been Tested? Manually verified that each example script can still be executed directly (`ruby examples/http_client.rb`, `ruby examples/streamable_http_client.rb`). No automated tests cover files under `examples/`. ## Breaking Changes None. The files under `examples/` are standalone scripts and are not part of the gem's public API.
atesgoral
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The example files
examples/http_client.rbandexamples/streamable_http_client.rbare intended to be run as standalone scripts and are not designed to be reused as modules (e.g., viarequire). Theif __FILE__ == $PROGRAM_NAMEguard therefore serves no purpose and is removed.How Has This Been Tested?
Manually verified that each example script can still be executed directly (
ruby examples/http_client.rb,ruby examples/streamable_http_client.rb). No automated tests cover files underexamples/.Breaking Changes
None. The files under
examples/are standalone scripts and are not part of the gem's public API.Types of changes
Checklist