fix(server): complete empty listen subscriptions - #2743
Closed
SoulmatelynchVFX wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: c549642 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
SoulmatelynchVFX
force-pushed
the
codex/fix-empty-subscriptions-listen
branch
from
September 4, 2026 07:36
3dd415e to
c549642
Compare
Author
|
Closing in favor of #2651, which covers the same fix and includes the matching E2E capacity-guard adjustment. Thanks for the heads-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2650.\n\n## Summary\n- acknowledge and immediately complete subscriptions/listen when no requested notifications are honored\n- avoid creating a bus subscription or keep-alive timer for a stream that cannot deliver events\n- add a regression test for the empty-honored-filter lifecycle\n\n## Tests\n- �itest run test/server/createMcpHandlerListen.test.ts\n- Server typecheck\n- Prettier and ESLint for the changed source