Added 'public_ip' as an option for periphery configuration - #1568
Open
KapralMark wants to merge 3 commits into
Open
Added 'public_ip' as an option for periphery configuration#1568KapralMark wants to merge 3 commits into
KapralMark wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
public_ipoption to Periphery (env:PERIPHERY_PUBLIC_IP) thatsets the host address explicitly instead of resolving it via OpenDNS.
Why
Periphery discovers the host public IP by querying the OpenDNS resolvers.
On air-gapped/offline networks that query can't be executed, and it causes the 'Server'
page to show
Unknown IPfor the machine.Changes
client/core/rs/src/entities/config/periphery.rspublic_ipbin/periphery/src/config.rspublic_ipenvironment value, falling back to the config valuebin/periphery/src/state.rspublic_ipinstead of querying the OpenDNS resolversconfig/periphery.config.tomlpublic_ipBehavior
Quick note: This change is cosmetic only. The
public_ipvalue isn't used in any place other than the 'Server' tab.Testing
cargo build- succeeds.cargo test- succeeds.rustfmt --check- succeeds.PERIPHERY_PUBLIC_IPset as an environment variable, the Server page shows the configuredvalue and doesn't try to send an OpenDNS query.