feat: add network backup location awareness - #73
Closed
AJV20 wants to merge 3 commits into
Closed
Conversation
Owner
|
Thanks for the substantial work here. I completed independent standards, spec, correctness, and security reviews. I cannot merge this safely in its current form:
The review also uncovered a pre-existing tar option-injection flaw in archive inspection. That flaw predates this PR, so I am not attributing it to this change; I am fixing it separately on main before release. Fixing the introduced issues would require redesigning the immutable archive snapshot/capacity strategy and revalidating the mount-event state machine, which is beyond a safe maintainer patch to this PR. I am closing it instead of risking backup loss, disk exhaustion, or a misleading partially-working network mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety details
/Volumes/<share>destination is never recreated as a directory on the startup disk.Verification
python3 Scripts/regression/run.py— 164 checksswift buildswift build -c releasebash Scripts/build.shplutil -lintfor all seven localizationsScripts/benchmark-performance.shScope
This is the focused mount-awareness portion of #52. The temporary local cache and verified migration queue remain intentionally deferred to a separate security-focused change.