Fix to soil colour initialisation - #48
Draft
mpaiao wants to merge 6 commits into
Draft
Conversation
…tly when soil colour is not available. There may have been a uninitialisation problem for glaciers/oceans. Not sure if this will make any difference though.
… default values whenever we identify a grid cell with soil colour flagged as water. We no longer use the water soil colour to replace the values for soil class or land use.
…orarily added them to help debug the code.
11 tasks
mpaiao
marked this pull request as draft
August 18, 2026 18:29
Contributor
Author
|
Set it to draft before tests are finalised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note. This is identical to #47, but the source branch name was confusing as it had the same name as the release. That pull request is now closed.
Pull Request Description
It turned out that my previous pull request to initialise spatially heterogeneous soil colour was crashing the model under some configurations. This pull request is an attempt to fix it.
In short, I made 3 modifications:
I made some initial tests on Jaci and it seems to be running for 12 UTC initialisations. It is still unclear to me why the first PR would work at 00 UTC but not at 12 UTC. I suspect some pixel with inconsistent ocean/land flags existed on a place where it is nighttime at 00 UTC and daytime at 12 UTC.
Type of Change
Testing and Quality
Scientific Impact
Hopefully this PR will allow MONAN-2.0.0-rc to run at 00 UTC and 12 UTC.