Migrate from Scalatest to MUnit

[alexandru]

No description provided.

[alexandru]

/oc /review PR

[opencode-agent]

PR Review: Migrate from Scalatest to MUnit

This is a clean, mechanical migration. The changes are consistent across all 18 files. A few points:

What's good

• All test suites correctly switched from org.scalatest.funsuite.AnyFunSuite to munit.FunSuite
• assert(a === b) correctly replaced with assertEquals(a, b) for better error messages
• succeed → () is the correct MUnit equivalent for an empty pass
• The reusable munitTestDependency in build.sbt is clean and avoids duplication
• illTyped from Shapeless is framework-agnostic (compile-time macro), so no changes needed there

Items worth noting

1. assertEquals[Any, Any](v, ea1) in NewsubtypeValidatedSuite.scala:46 and NewtypeValidatedSuite.scala:43 — This widens both types to Any. It works because Newsubtype is a runtime-subtype of the underlying String, but it's fragile. Consider assertEquals(v, ea1.value) to compare at the correct type level.

2. Native test-interface exclusion (build.sbt:26) — The .exclude("org.scala-native", s"test-interface_native0.5_${scalaBinaryVersion.value}") may be needed to avoid conflicts with sbt-scala-native, but there's no comment explaining why. If the project does run tests on Native (the core project defines a native platform), this exclusion could prevent test execution there. Worth verifying or adding a comment.

3. assert usage in integration suites — The Circe/PureConfig integration suites still use Predef's assert, which works fine in MUnit but doesn't give the improved diff output that assertEquals provides. Not a blocker, since those assertions are on Either/Boolean values.

Verdict

LGTM. The migration is correct and consistent. No blocking issues.

opencode session  |  github run