Skip to content

feat(derivation): skip L1 fill-gap derivation for pre-upgrade blocks#981

Merged
tomatoishealthy merged 1 commit into
feat/sequencer-finalfrom
feat/local-verify-preupgrade-guard
Jun 8, 2026
Merged

feat(derivation): skip L1 fill-gap derivation for pre-upgrade blocks#981
tomatoishealthy merged 1 commit into
feat/sequencer-finalfrom
feat/local-verify-preupgrade-guard

Conversation

@tomatoishealthy

Copy link
Copy Markdown
Contributor

In local-verify mode, when a batch's last block is missing locally and its firstBlockNumber is below the verifier's VerificationStartHeight, wait for P2P/blocksync backfill instead of running L1 fill-gap derivation. Pre-upgrade (pbft-era) blocks are held by geth but not tracked at the node layer, so reconstructing them via L1 would diverge geth's height from the node's on restart. VerificationStartHeight returns MaxUint64 while the verifier history is empty, so every missing block is treated as pre-upgrade until it loads.

Also log a one-line sequencer-contract state snapshot at verifier startup (active sequencer + verification start height), and bump morph-l2/go-ethereum to the latest pinned revision.

In local-verify mode, when a batch's last block is missing locally and its
firstBlockNumber is below the verifier's VerificationStartHeight, wait for
P2P/blocksync backfill instead of running L1 fill-gap derivation. Pre-upgrade
(pbft-era) blocks are held by geth but not tracked at the node layer, so
reconstructing them via L1 would diverge geth's height from the node's on
restart. VerificationStartHeight returns MaxUint64 while the verifier history
is empty, so every missing block is treated as pre-upgrade until it loads.

Also log a one-line sequencer-contract state snapshot at verifier startup
(active sequencer + verification start height), and bump morph-l2/go-ethereum
to the latest pinned revision.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@tomatoishealthy tomatoishealthy requested a review from a team as a code owner June 8, 2026 09:01
@tomatoishealthy tomatoishealthy requested review from SecurityLife and removed request for a team June 8, 2026 09:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb86a4e3-5ba6-4902-8c13-a648c7a9ed41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/local-verify-preupgrade-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomatoishealthy tomatoishealthy merged commit d02fbc2 into feat/sequencer-final Jun 8, 2026
8 of 9 checks passed
@tomatoishealthy tomatoishealthy deleted the feat/local-verify-preupgrade-guard branch June 8, 2026 09:25
tomatoishealthy added a commit that referenced this pull request Jun 9, 2026
…981)

Co-authored-by: allen.wu <allen.wu@bitget.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants