Skip to content

Fix shell injection vulnerability in Docker release workflow inputs #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarvelFisher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix shell injection vulnerability in Docker release workflow inputs #982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/docker_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ jobs:
with:
ref: ${{ inputs.tag || github.ref }}

- name: Verify checkout ref matches expected tag
env:
INPUT_TAG: ${{ inputs.tag || github.ref_name }}
run: |
EXPECTED="${INPUT_TAG}"
ACTUAL=$(git tag --points-at HEAD | head -1)
if [[ "$EXPECTED" != "$ACTUAL" ]]; then
echo "ERROR: HEAD does not point to expected tag $EXPECTED (got: $ACTUAL)"
exit 1
fi

- name: Set up QEMU
uses: docker/setup-qemu-action@v4

Expand All @@ -41,8 +52,10 @@ jobs:

- name: Extract version and commit
id: meta
env:
INPUT_TAG: ${{ inputs.tag || github.ref_name }}
run: |
TAG="${{ inputs.tag || github.ref_name }}"
TAG="${INPUT_TAG}"
if ! [[ "$TAG" =~ ^v[0-9]+\.[0-9]+\.[0-9]+([.-][0-9A-Za-z.-]+)?$ ]]; then
echo "Invalid release tag: $TAG (expected e.g. v0.5.0)"
exit 1
Expand All @@ -61,6 +74,6 @@ jobs:
push: true
tags: |
${{ env.IMAGE_NAME }}:${{ steps.meta.outputs.version }}
${{ env.IMAGE_NAME }}:latest
${{ github.event_name == 'push' && format('{0}:latest', env.IMAGE_NAME) || '' }}
cache-from: type=gha
cache-to: type=gha,mode=max